Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1709709ybh; Sun, 15 Mar 2020 09:10:05 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtzP9vkDbHs+K9xqlljIbDLPHAsChA5xCJlmPf96nciOp696ZKnzI+3xLGUeaE2PT1xMbBG X-Received: by 2002:aca:d985:: with SMTP id q127mr13945905oig.132.1584288605439; Sun, 15 Mar 2020 09:10:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584288605; cv=none; d=google.com; s=arc-20160816; b=I9Jq4GbBG51+qnhTpFnmuz5W4W9cFHFiIsz0tTBMWF6nu70lE5JpJwtgTBuvRXm0gS 5/+BURCCyUQ17++dMJireXgsKmZuVcplljWmJIpl+HRxGXPyHE7jsswDe98rTEvcMnzI 2XdbVRKqPQJthioCjt+PI7nzrOw7I8k/uweUJYLTcpJSKC+SluscEtYg0/6GZIvBamPb xsISCamQgFkskMGA+nPsMJKllhXICrX6I1G9XerTMZCajLr1qJbekUiUGdTcZ9QM3/TZ RuVzZiddEky2vl55nlikEcH/hp+/4/KMCaMLj5bT5wW9fHYEKWT2Uc8WsNW/iRHzDNDn U93w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ZvfpCDi2rKJmJAvsmnRekrSK8tNLi3wzOk8K48DUov4=; b=WonWEpMNOgVYihpkWUk0x4MnM/FX+poFagFMq5D7ZAtHHjqLH14FkqQdC3Z+xIXHFU aRF0TGDU+vS3l30Czr5NYvmOaWi8wfsCK3ftuzVA5OvtEC5oWeCqUdDKIt7ma+gfyBoP Qwq23G+imlJClZBm7augLsXrClVM6ZiWwsRzQ0nWcZBph/tNoh42QN0fmW3scMjAfw0e sbzMqJ+1yqsmCqQXQhVQ4zJpQGc+ck76qjpLd5dT70iBl4TlX10nP024NLdZIYfKuSCB jzWXIQVNXXyX/ae23OV1+UICm/lKNgSDxJuIw0LRz93aMPNJhvRG85VDzGTyCGnIJzab /jdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VEVmLLl3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w17si2361160oti.74.2020.03.15.09.09.52; Sun, 15 Mar 2020 09:10:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VEVmLLl3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728714AbgCOQJ3 (ORCPT + 99 others); Sun, 15 Mar 2020 12:09:29 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:60523 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728310AbgCOQJ3 (ORCPT ); Sun, 15 Mar 2020 12:09:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584288568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZvfpCDi2rKJmJAvsmnRekrSK8tNLi3wzOk8K48DUov4=; b=VEVmLLl3o/o99yAGae+Z7oe62Xi877YCemcSKy/At06p9ldXzq/mC+hrDjZ6s3sJO7AWCz /w/G68cl9HmEhC6z5ifyTPWQvNbqQN2ZFuIvmy/hgDXZvF2nsF5R801Q092z4WC8tZq+3U tJTPtQGqShfwo9Q2zo2xn4FmuV7u1sU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-2V2UxltzP0Kalk5PHP7k8Q-1; Sun, 15 Mar 2020 12:09:24 -0400 X-MC-Unique: 2V2UxltzP0Kalk5PHP7k8Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91B06189D6C0; Sun, 15 Mar 2020 16:09:23 +0000 (UTC) Received: from treble (ovpn-120-135.rdu2.redhat.com [10.10.120.135]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A05E59CA3; Sun, 15 Mar 2020 16:09:22 +0000 (UTC) Date: Sun, 15 Mar 2020 11:09:19 -0500 From: Josh Poimboeuf To: Peter Zijlstra Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [RFC][PATCH 05/16] objtool: Optimize find_symbol_by_index() Message-ID: <20200315160919.zd7phtq7ejyq4kva@treble> References: <20200312134107.700205216@infradead.org> <20200312135041.699859794@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200312135041.699859794@infradead.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2020 at 02:41:12PM +0100, Peter Zijlstra wrote: > The symbol index is object wide, not per section, so it makes no sense > to have the symbol_hash be part of the section object. By moving it to > the elf object we avoid the linear sections iteration. I remember there was a specific reason for this oddity, but it eludes me now. This does make sense, assuming it doesn't break anything. -- Josh