Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1710711ybh; Sun, 15 Mar 2020 09:11:10 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvDKCuet26Kq0uEeImbtI3fClY3UCRqzAsvuCihxKxze6r4O51dgCjePBhKZtU6BfsyBkiF X-Received: by 2002:a9d:7f98:: with SMTP id t24mr2626188otp.10.1584288670593; Sun, 15 Mar 2020 09:11:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584288670; cv=none; d=google.com; s=arc-20160816; b=faZk/QG6pHJn69uVVDlxfNl+D2wgsNPCJP0hqm1WzBHsheuF3yWS6syVIDBVD+yC8C hXbPrluCfRSDPOrKyTig1H0bfb0ARMMnbiKktJAxPuOL64BDwJBxmQDPqYXvr8Z12fo6 MHcXo7UKKzrJopfzzz3/J5+5laoOR4SdhWKdN67yNQYTLUsG1q3I2KdH5+YMd8EJqDZB WBnJB5khfJm9C04s8BYyW3JZRrX/6r2aY9Pe0tCzqpp0MteB21dfgP9k6Pn4JR/2kncX Rr5eLfnThn3xNloAR2oDnCc4BHDK+AhJQ4A+5ALW7BNd/w+I/fvQrwM7kdIhf3ghVFdx E51A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=W4Lm0YoP4KDolNEvyKr/Lt/aezU7JGREH2+Ds0TgmAY=; b=chD4JCZhYoDZGpk7YoUHPgXpD8ENxOQKVeuQYEcLmSbMREx7lsR4yD3KmRbV019fDz auqDY041HBldQWbJT7tbzKnPoBxxRn7dEwsxOLTa5i8x7NUkxJO39J+4+hVYgP7inHXV y/T9GXZLpI9Erl5qKJWHvfDgO7AUr6CBFURsBIdE69jMYkACAX8syKzJrOF3n52XI7A5 3h9ul1aVmfD4HIlj6g6/ec6flT+L4RLJNXYDoSO+I5X/c2Bc5QPdANUhSbUvSxGkQyRg NdjtwVEVq8Qzv/WdENqImDZAHIT7rghcsLSSsT0m48w4WYmvLBFHkpFgxmvCoNJZmLGL LRPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DO6GeAGh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k201si8829108oib.94.2020.03.15.09.10.57; Sun, 15 Mar 2020 09:11:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DO6GeAGh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728917AbgCOQKg (ORCPT + 99 others); Sun, 15 Mar 2020 12:10:36 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:48244 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728695AbgCOQKg (ORCPT ); Sun, 15 Mar 2020 12:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584288635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W4Lm0YoP4KDolNEvyKr/Lt/aezU7JGREH2+Ds0TgmAY=; b=DO6GeAGhexHr+zcDyqeIu+M7buBDogGI3Ggo7qqGB6/fP/QQDYs8NiYIe6XHFFEHdF6WXq PixoRaeppexXnsVWu1J5FCZSdSMqBvT+if+MYZEwEhqk2CJuEN2UD25pXSu50ZB2GWNScL orxD0gxZbmElYaeTYXhOMu9VoCP3Bg4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-232-D271xW-5NYyG8jvhhIqL9g-1; Sun, 15 Mar 2020 12:10:34 -0400 X-MC-Unique: D271xW-5NYyG8jvhhIqL9g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 037BA189D6C0; Sun, 15 Mar 2020 16:10:33 +0000 (UTC) Received: from treble (ovpn-120-135.rdu2.redhat.com [10.10.120.135]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5586310027A7; Sun, 15 Mar 2020 16:10:32 +0000 (UTC) Date: Sun, 15 Mar 2020 11:10:30 -0500 From: Josh Poimboeuf To: Peter Zijlstra Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [RFC][PATCH 05/16] objtool: Optimize find_symbol_by_index() Message-ID: <20200315161030.5rzgnk7qvaof4zzx@treble> References: <20200312134107.700205216@infradead.org> <20200312135041.699859794@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200312135041.699859794@infradead.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2020 at 02:41:12PM +0100, Peter Zijlstra wrote: > @@ -289,7 +286,8 @@ static int read_symbols(struct elf *elf) > } > sym->alias = alias; > list_add(&sym->list, entry); > - hash_add(sym->sec->symbol_hash, &sym->hash, sym->idx); > + > + hash_add(elf->symbol_hash, &sym->hash, sym->idx); Unnecessary added whitespace. -- Josh