Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1893101ybh; Sun, 15 Mar 2020 13:46:24 -0700 (PDT) X-Google-Smtp-Source: ADFU+vudcpOgmrBmLy/PUf8mIGnD11mqb5uJAWfJ87oll5RkbFuOAUS02RiLc+qefx7rK3NeyBUG X-Received: by 2002:a05:6830:1e96:: with SMTP id n22mr2925994otr.189.1584305184381; Sun, 15 Mar 2020 13:46:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584305184; cv=none; d=google.com; s=arc-20160816; b=luNJbAKCA4Gt9AawErY1+NieWB70EX5CDGp+g9pDia/+JV+UqltzBdPDgLv01dhhLg zGW+6AIhINvhfmbRIWNeDBP6sqB0UYY0tdBXIpsVOuAT8q/IYUcKvJZi0UPNQtY+RRxv t3Ggz+DGgrxttrQ4W4dpshiNNUFWzGRV7bkMrv3xEtqe39NB1hgpLevF+VG7qxq7o0J1 3AjvxXqo+26+1VDuksPC0RFRotgh9CwUJ6OKP25tSmwc9lDEFT3aia4PXPM5pKzQ2G48 UNxrscIcSG4febNCYI1AbfVzutAbhiWWaHBU+wDwpx5JqUNtgwTmJIaC2NzC2P0+86OI DAaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Mu+oEFJmu1E+EREsbDjlIvvdw3BrLQvsr75wDNZTH8s=; b=nMThMUdP3STgT7Rxx0oTDc3DJgKUlWp54gM307T909o/OiIzRff/2xrRILtnNyGJiQ cNmXzPFsMPU6hzXX9sJGx/10ZCasf+UPoL1ee3ItDOH+l6zFvj6r6nQX6MDXqueqHSkg KMgzKqCkscXwMSS2OQyn2pfd6UdLzJzaLm9K3iNumQWfOeV1kCieSVCtR4oy4Kz88uRx Un7Y1c3vYWR/cYKq2+IqRhQmQgtplwvY4Y9dPauc5NFEo+YEU4HKv3b7yj9Da7O63jpZ MwCn2GHsRXZNCBSl/3ZfDjfrtQn8aP4XSf+khcMOKbDpHtwBxRlIK4feWqfjQJvVir/C YRlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c4si8060038otp.218.2020.03.15.13.46.00; Sun, 15 Mar 2020 13:46:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729171AbgCOUok (ORCPT + 99 others); Sun, 15 Mar 2020 16:44:40 -0400 Received: from correo.us.es ([193.147.175.20]:54836 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729159AbgCOUok (ORCPT ); Sun, 15 Mar 2020 16:44:40 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 7DCDAE8B68 for ; Sun, 15 Mar 2020 21:44:11 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 70FDADA38D for ; Sun, 15 Mar 2020 21:44:11 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 667B7DA840; Sun, 15 Mar 2020 21:44:11 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 80597DA72F; Sun, 15 Mar 2020 21:44:09 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Sun, 15 Mar 2020 21:44:09 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 5464E4251480; Sun, 15 Mar 2020 21:44:09 +0100 (CET) Date: Sun, 15 Mar 2020 21:44:35 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Haishuang Yan Cc: Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] netfilter: nf_flow_table: reload ipv6h in nf_flow_nat_ipv6 Message-ID: <20200315204435.25kji3x5me72xjgg@salvia> References: <1584281705-26228-1-git-send-email-yanhaishuang@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584281705-26228-1-git-send-email-yanhaishuang@cmss.chinamobile.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 15, 2020 at 10:15:02PM +0800, Haishuang Yan wrote: > Since nf_flow_snat_port and nf_flow_snat_ipv6 call pskb_may_pull() > which may change skb->data, so we need to reload ipv6h at the right > palce. Could you collapse patch 1/4 and 2/4 ? Same thing with patches 3/4 and 4/4 ? Thanks.