Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2165958ybh; Sun, 15 Mar 2020 20:49:20 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuJkBRrKSs6XJZCTuYt7UVDKKcLcUsW8UBKz1n5n61calPwpYTq/WTQ50QfIMwGF1+G9QDe X-Received: by 2002:aca:c7c5:: with SMTP id x188mr16203129oif.130.1584330560188; Sun, 15 Mar 2020 20:49:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584330560; cv=none; d=google.com; s=arc-20160816; b=k/PgWYjDVwvc7dN0QhNjyq7Usttc47D/5vy4wmPgK31ki/d9TSmpKruHacH8ydgjZR 48/jVGUkDoQVF1Cmp3p41PqKKC9Z7LLKdxB6oTwWVEezUhrfpnrMZcp7mxmp/D05EYu6 Wj6XeEDuziKdA981+adUWBL6X3QLi0L0tGJXj/CwvTX44F4JlXD+RtcrTz572GMMUeU9 pnLU5+Ux9MiBuY0OS5x8nzAHV35hjq6hPpIKZ2nMrpM8fhUpJ+E/maSHz2ihrYdNBY/P JQPeO4amUxXNYRKkN/HVnFC0jLQie8kEWQVol9ms2wepKpW9YdjKJMv4/7+ZZamPH01J Grmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=Atb7ahVS8LUf9Mw0E/eSUIN7FbpFMfiriqfWMTwpgvI=; b=ZMzeBtg7oBdDG0faKf2E/nVgk8P+9427/hk/fa9/NzuRfe7kY+MOC+hEWXvhqv8sY8 MlWuJ9FYg1FW5i2qVc5bpxYhGDa3kN5uYg5FIrg/SsBBJTQPdB9lyUzb5Cv/QscqCWbI JFFGo0DL78ZY+Drz5u1tWTkBUua4wBrm9UK8yTzDnS8QKA20Lj/KTwnfLALwkIH6Cp/D ZYEEv94nxW7NPS1n3WBxd+5u4PYmehPQhut6HZJEzM5uuT2ZS71uivbw5T07khk8/esG q0iH9+wIIR7x4d79QPG8inmYjZKUhBn/Dfl5aXy5sb2e5ujCi8a0NZZTmYBvzxrCnc0p 3l1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x14si9279411oto.47.2020.03.15.20.49.07; Sun, 15 Mar 2020 20:49:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729494AbgCPDqm (ORCPT + 99 others); Sun, 15 Mar 2020 23:46:42 -0400 Received: from m176115.mail.qiye.163.com ([59.111.176.115]:31259 "EHLO m176115.mail.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729387AbgCPDqm (ORCPT ); Sun, 15 Mar 2020 23:46:42 -0400 Received: from localhost.localdomain (unknown [58.251.74.226]) by m176115.mail.qiye.163.com (Hmail) with ESMTPA id E3695663D0F; Mon, 16 Mar 2020 11:46:37 +0800 (CST) From: Zheng Wei To: Catalin Marinas , Will Deacon , Brian King , "James E.J. Bottomley" , "Martin K. Petersen" , Kate Stewart , Thomas Gleixner , Hanjun Guo , Greg Kroah-Hartman , Yunfeng Ye , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Cc: kernel@vivo.com, wenhu.wang@vivo.com, Zheng Wei Subject: [PATCH v2,RESEND] scsi/ipr: fix wrong __VA_ARGS__ usage Date: Mon, 16 Mar 2020 11:46:29 +0800 Message-Id: <20200316034631.126018-1-wei.zheng@vivo.com> X-Mailer: git-send-email 2.17.1 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZTlVLSE9CQkJDT0xPSklKSllXWShZQU hPN1dZLVlBSVdZCQ4XHghZQVk1NCk2OjckKS43PlkG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Nio6Pzo6Kjg4GjcrQwkVKBoS OToaC0hVSlVKTkNPSEhLSEJDTUNCVTMWGhIXVQweElUBEx4VHDsNEg0UVRgUFkVZV1kSC1lBWU5D VUlOSlVMT1VJSU1ZV1kIAVlBSU1NSDcG X-HM-Tid: 0a70e1735b759373kuwse3695663d0f Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ipr_hcam_err uses __VA_ARGS__ without "##" prefix, it causes a build error when there is no variable arguments. Signed-off-by: Zheng Wei --- changelog v1 -> v2 - resend for the failure of delivery to some recipients. drivers/scsi/ipr.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ipr.h b/drivers/scsi/ipr.h index b97aa9ac2ffe..de3401972354 100644 --- a/drivers/scsi/ipr.h +++ b/drivers/scsi/ipr.h @@ -1813,14 +1813,14 @@ struct ipr_ucode_image_header { hostrcb->hcam.u.error64.fd_res_path, \ hostrcb->rp_buffer, \ sizeof(hostrcb->rp_buffer)), \ - __VA_ARGS__); \ + ##__VA_ARGS__); \ } else { \ ipr_ra_err((hostrcb)->ioa_cfg, \ (hostrcb)->hcam.u.error.fd_res_addr, \ - fmt, __VA_ARGS__); \ + fmt, ##__VA_ARGS__); \ } \ } else { \ - dev_err(&(hostrcb)->ioa_cfg->pdev->dev, fmt, __VA_ARGS__); \ + dev_err(&(hostrcb)->ioa_cfg->pdev->dev, fmt, ##__VA_ARGS__); \ } \ } -- 2.17.1