Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200316072419.65274-1-chentsung@chromium.org>
In-Reply-To: <20200316072419.65274-1-chentsung@chromium.org>
From:   Nicolas Boichat <drinkcat@chromium.org>
Date:   Mon, 16 Mar 2020 15:50:53 +0800
Message-ID: <CANMq1KD1dLzd3cYmdsg5wF5z-prtdq41P8fuzDQomX=6UbZpeg@mail.gmail.com>
Subject: Re: [PATCH] HID: google: add moonball USB id
To:     Chen-Tsung Hsieh <chentsung@chromium.org>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Looks better with the mailing lists cc-ed, thanks!

On Mon, Mar 16, 2020 at 3:24 PM Chen-Tsung Hsieh <chentsung@chromium.org> wrote:
>
> Add 1 additional hammer-like device.
>
> Signed-off-by: Chen-Tsung Hsieh <chentsung@chromium.org>

Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

> ---
>  drivers/hid/hid-google-hammer.c | 2 ++
>  drivers/hid/hid-ids.h           | 1 +
>  2 files changed, 3 insertions(+)
>
> diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
> index 2aa4ed157aec..85a054f1ce38 100644
> --- a/drivers/hid/hid-google-hammer.c
> +++ b/drivers/hid/hid-google-hammer.c
> @@ -532,6 +532,8 @@ static const struct hid_device_id hammer_devices[] = {
>                      USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MAGNEMITE) },
>         { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
>                      USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MASTERBALL) },
> +       { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
> +                    USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MOONBALL) },
>         { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
>                      USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_STAFF) },
>         { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 3a400ce603c4..33fddab41722 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -478,6 +478,7 @@
>  #define USB_DEVICE_ID_GOOGLE_WHISKERS  0x5030
>  #define USB_DEVICE_ID_GOOGLE_MASTERBALL        0x503c
>  #define USB_DEVICE_ID_GOOGLE_MAGNEMITE 0x503d
> +#define USB_DEVICE_ID_GOOGLE_MOONBALL  0x5044
>
>  #define USB_VENDOR_ID_GOTOP            0x08f2
>  #define USB_DEVICE_ID_SUPER_Q2         0x007f
> --
> 2.25.1.481.gfbce0eb801-goog
>