Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2365238ybh; Mon, 16 Mar 2020 01:39:51 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtq6EVBF+5KQp6S1sJ6zsX11ABiDmzMMwTk7fMxnsMnutzBOTLAatpUgCTKFAkhq1vBA9pu X-Received: by 2002:aca:682:: with SMTP id 124mr218964oig.69.1584347991175; Mon, 16 Mar 2020 01:39:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584347991; cv=none; d=google.com; s=arc-20160816; b=Ihv3GRgYun39NgZx+d5KaH0z5CLfS69wtkXCtaGQOMsfjIc8n38pIRGRSUtW/7i+8G FeQ96q1sbA03elBOY2d038hiL2cw4KAWhfsudlcYTY4vhYPQdZQuJl9PdqqGBrDIuw58 wn1Mc0ZFqcXpVagvVOrX+S56+vKu+NdJxz/bMXeCqvqAXmH90G/I0NX4si1X/L2bhrV0 JcPuzMI8oku+vrOcBL0HFnCEt5jl036iUk5Bmw6G/wQs8t/hGWnev542mrzjhVyRcPLp cKcjVSWY9rX9uKayGCa7wBb97ceWZgorQvbiTt9U2ZT3RaLaK1hESAIciq9qIQC/OYJE yEuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=TtkfRSDe6o7Z/1gs+iHN17ftOwc8JIAXk7wFtYfnt08=; b=SCorvNkbp9C8hGCfQxCh4fkE7vT+8ahINJKVj2Y9kImChNotxSsuZ7O6IYd+9TIpfL dcp7fMx3m/BEQ0S3/alp5BVnhL9JjZyVHIj41qb8ZNGsiai+IogRj3EvR+5aP88mqcZX avtv7OWCF6gmOKKBiCH6/t9F1UJTgXZfBrn7GUayqW69o1nnq9zRPX7eATLBZ9xTLPKV /an4LMkhR6MGdJujMicY5XRBFnZS0QR0w8opJ095sOUm40rY6jPQAFHbLN2IjJOH9DoG dxG/UVQjJhP+HpYPI1vTEBUQdgHSJhpGF5hcgcPR+GZOLOJVuCQOJG9tBg0KFMQfpzsT lZow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q196si4381975oic.143.2020.03.16.01.39.37; Mon, 16 Mar 2020 01:39:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730132AbgCPIiv (ORCPT + 99 others); Mon, 16 Mar 2020 04:38:51 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:51216 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730048AbgCPIiv (ORCPT ); Mon, 16 Mar 2020 04:38:51 -0400 Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jDlGo-0002u8-JF; Mon, 16 Mar 2020 09:38:46 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 06B1D100F5A; Mon, 16 Mar 2020 09:38:45 +0100 (CET) From: Thomas Gleixner To: Prasad Sodagudi , john.stultz@linaro.org, sboyd@kernel.org Cc: linux-kernel@vger.kernel.org, saravanak@google.com, tsoni@codeaurora.org, tj@kernel.org, Prasad Sodagudi Subject: Re: [PATCH 2/2] sched: Add a check for cpu unbound deferrable timers In-Reply-To: <1584326350-30275-3-git-send-email-psodagud@codeaurora.org> References: <1584326350-30275-1-git-send-email-psodagud@codeaurora.org> <1584326350-30275-3-git-send-email-psodagud@codeaurora.org> Date: Mon, 16 Mar 2020 09:38:45 +0100 Message-ID: <874kuoelt6.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Prasad Sodagudi writes: > @@ -948,6 +949,11 @@ static void __tick_nohz_idle_stop_tick(struct tick_sched *ts) > ktime_t expires; > int cpu = smp_processor_id(); > > +#ifdef CONFIG_SMP > + if (check_pending_deferrable_timers(cpu)) > + raise_softirq_irqoff(TIMER_SOFTIRQ); > +#endif So if that raises the soft interrupt then the warning in can_stop_idle_tick() if (unlikely(local_softirq_pending())) { .... pr_warn() will trigger. Try again. Thanks, tglx