Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2367368ybh; Mon, 16 Mar 2020 01:42:58 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt/NYxZZ9dcH5xsN4KfGLxmVtL05n8kfjlbwZpdrVr5JXe3RO2OmidX0m59VsUx+cI1c3oU X-Received: by 2002:a9d:3661:: with SMTP id w88mr20520578otb.223.1584348178628; Mon, 16 Mar 2020 01:42:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584348178; cv=none; d=google.com; s=arc-20160816; b=mWa2bVbLBIjR1hwWiSi5QUv/cOcENhkclfufmcfJuRuV+pdMzzYzf4O6APjrIXcOiR qthcvaBPvS7AM1wJgs4stqJMhMxuKYBd4YM4L1fv8la5BVtQJ8ftPLTApuTHpAr+S97s l2MXNuLgE3XN4/MolWkmc02CMl8x55SIKvBNSNOWfl7AonnfD9dJcagC3hoczS0SPdpA /pFNkcCKMICw6O/0546SQUN43MahaQfX/b1urUEBCrqp9udcf9BioABAPptf07FyVHt4 DXUfmxr9DQFniXBC+JPPk7P9n6BiIdEboKXMPLUxtYEpRirtGsXUvWky3STRVoJYVhlf u6KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=0EkQEFT2vUY55El3m7JE4RQejWgK3YochirWgvfvLK0=; b=yRaTVoGvz5fvu2n+ZjNkD/vHIXvc/38MmnMnBVkJ4R77Nk7jumwy/MEgm228LrHJsx 2xt5EgBPPdMUsJUVRFck8YW9FizutnMNMz62VDYJgJq1jhCywGU4sR24ccWdSrfRFDYJ t/PBzujs0UlzD36qgmXtQ9pHpO2xBn0/ouvIfNzlFvSh/O+aw5INHGrG9XmfzhhwLgQK qYssO5qE8gvmZK5eA76UrChShblDmvM29nOmbApfZMsOMjoTaPcPSrIpxgbH8ua5KxEb M29HhHyk+6ZZcylNZSsujSWswuhHqwJarHhQuR2GPHGTFKZaA3iq2+azG7iLGcjLGAQn qWHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m14si4139556otn.34.2020.03.16.01.42.44; Mon, 16 Mar 2020 01:42:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730321AbgCPIlE (ORCPT + 99 others); Mon, 16 Mar 2020 04:41:04 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:59511 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730167AbgCPIlD (ORCPT ); Mon, 16 Mar 2020 04:41:03 -0400 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id A7614C000D; Mon, 16 Mar 2020 08:40:56 +0000 (UTC) Date: Mon, 16 Mar 2020 09:40:56 +0100 From: Alexandre Belloni To: Anson Huang Cc: Shawn Guo , Peng Fan , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "dmitry.torokhov@gmail.com" , "a.zummo@towertech.it" , "rui.zhang@intel.com" , "daniel.lezcano@linaro.org" , "amit.kucheria@verdurent.com" , "wim@linux-watchdog.org" , "linux@roeck-us.net" , Daniel Baluta , "gregkh@linuxfoundation.org" , "linux@rempel-privat.de" , "tglx@linutronix.de" , "m.felsch@pengutronix.de" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "ronald@innovation.ch" , "krzk@kernel.org" , "robh@kernel.org" , Leonard Crestez , Aisheng Dong , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Message-ID: <20200316084056.GG4518@piout.net> References: <1583714300-19085-1-git-send-email-Anson.Huang@nxp.com> <20200316005219.GD17221@dragon> <20200316030744.GC17221@dragon> <20200316033447.GE17221@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/03/2020 08:04:17+0000, Anson Huang wrote: > Hi, Shawn > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU > > case > > > > On Mon, Mar 16, 2020 at 03:18:43AM +0000, Peng Fan wrote: > > > Just sent out. One more thing, I think all drivers depends on IMX_SCU > > > should not have COMPILE_TEST if we plan not to add dummy functions. I > > > see you picked up Anson's patch in imx/drivers branch, please check more. > > > > Ha, yes. COMPILE_TEST should be dropped for IMX_SCU_PD in Anson's patch. > > Thanks for reminding. > > I still NOT quite understand why we won't support COMPILE_TEST for SCU drivers, > with whose stubs, the build should be OK, if there is any build error, we should try > to fix it, NOT just remove the COMPILE_TEST support, any special reason? > COMPILE_TEST is supported as long as IMX_SCU is selected like is it for any driver depending on any bus. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com