Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2375103ybh; Mon, 16 Mar 2020 01:54:58 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuXafA2qtpOu23bggBrXdbWMee3Uch10rBY9VNTOcdEOkT+VI3+wnM5iVVUMSUYY/nT3xNc X-Received: by 2002:a05:6808:346:: with SMTP id j6mr106187oie.64.1584348898508; Mon, 16 Mar 2020 01:54:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584348898; cv=none; d=google.com; s=arc-20160816; b=dpNBRU5OQKOW5nPGTit4wuu8KNxus9NSiR8SnBr6e71Gl7rfB3y52j0NswUonmc0KG FeJQVHh4NfXoDY+fEhmwscbpNlhWpQlV9dA4/qzXRVraa+oW6+KAcDXA3ufGj5aFGLoP ks6in6yErBXhFv4zP6Zs+Yf5kxjqKUNZHM908XpKiVNiIPvmABdRN+fD9sW0ua245fY6 Cz2VMlkYtbmnmlc0viyUdsuWT6CyREwjHKk9mkyjLaSmBcOwD0DvwnjnJV/VqO8p1+vi 8QrrjW6cG+YPTXWH/7jP9G9B9m2V/AN7ZXRrpwhOMfBV9gTXZTI9LGXN5jaKNChq8puP Jzkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=YMlc//ixq3XAz7bfU0iD/j/ZWWxHdyHVImyXy4+oj0w=; b=00sSHXTg2yzXtlMGGwMnSaMunEJExSAmO+CcwmnXBfLUAud0/xn5NqaAHSOIT6xDed S+8APb+Ni7oBl96qOhUQQsb8wr4NKFabgx2PBaE1PRkG9Kovt6XAJ72BNZh+rsS5c4xM ERGhiSI6dTgPRdVO8cQdx83VucZcQ/I4Cu3Dy3c3h5wsi9nTU8tvmHWBmD8QcKd+mmly +Vui0Pr8T5OPpQzvpImyLkvCPp+lVxgVgiG8tX+8/75zNB6CvBi5pIou0ozeIenHrjG9 bz1/XS4Eu7nTLzKiF4xu/w1ZO5ybx0LzZeW3Tu/cSW+xSzjKidx/oJCNN71I0IORQxkX D3qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=ogCPnHc8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d27si9037657otf.22.2020.03.16.01.54.45; Mon, 16 Mar 2020 01:54:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=ogCPnHc8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730349AbgCPIyW (ORCPT + 99 others); Mon, 16 Mar 2020 04:54:22 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:32876 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730131AbgCPIyW (ORCPT ); Mon, 16 Mar 2020 04:54:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YMlc//ixq3XAz7bfU0iD/j/ZWWxHdyHVImyXy4+oj0w=; b=ogCPnHc8p7k5lQZBIXRcSs4Vtj hSpr0xLcM6zm2Q96u233tsR/wyxtUEzekj5Cc5cl6ro8AbRkl7dwiuVs2cv99SY2DERFiokTi7Ql6 WoDNj23VZ3e9297ZfSxiKEcfRGPdeVxoEzd4uDWjDf2gQdLAtLU5EvSAwTf+ucjjwLvDRV3vLkVoD pDnK4L/kNyqnmK+yL8xW6e1VPius7Qi3ze3rWSPCuIOcefGMbjJ/ctX4e+hlng47ZPNSqUXCzMaIe XWYVrMgAZA/+lKQGCI8a3rIOU5Dyr9acWqr8LgvRjJDMRBAo6/WN04LT5217b+J1MtIMA+T1ql2xw 4LMc1Ehg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDlVl-0001ty-Hu; Mon, 16 Mar 2020 08:54:13 +0000 Date: Mon, 16 Mar 2020 01:54:13 -0700 From: Christoph Hellwig To: Pingfan Liu Cc: linux-mm@kvack.org, Ira Weiny , Andrew Morton , Mike Rapoport , Dan Williams , Matthew Wilcox , John Hubbard , "Aneesh Kumar K.V" , Christoph Hellwig , Shuah Khan , linux-kernel@vger.kernel.org Subject: Re: [PATCHv6 1/3] mm/gup: rename nr as nr_pinned in get_user_pages_fast() Message-ID: <20200316085413.GA1831@infradead.org> References: <1584333244-10480-1-git-send-email-kernelfans@gmail.com> <1584333244-10480-2-git-send-email-kernelfans@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584333244-10480-2-git-send-email-kernelfans@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2020 at 12:34:02PM +0800, Pingfan Liu wrote: > To better reflect the held state of pages and make code self-explaining, > rename nr as nr_pinned. Looks good, Reviewed-by: Christoph Hellwig