Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2383718ybh; Mon, 16 Mar 2020 02:05:33 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtXo+2ciaFOhaKrY1cVEON6zpvDkAzS1u3KFW578zZB2eTUSHvZG97GgdtXRmqLzJJTT0dd X-Received: by 2002:a9d:17ec:: with SMTP id j99mr9473278otj.213.1584349533546; Mon, 16 Mar 2020 02:05:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584349533; cv=none; d=google.com; s=arc-20160816; b=Fz5bSeI58ALfitBvl9hcfk7HHarZWHzo0nYm8KSRV9sPOWiLWzFXj0eWYeEXFPPGG4 z8560v6Y1AjHaI/JZ3cFD5ywdd1DfvzrSHWbN3vhwNwLDA9z0f3sSomJV3wE1gSgz8ES +juLqFn8nmbl3J0LnHrsNqKjv3/rlQo786eLIWfQUysh71qiFcaTIKlfhPfR6anNog+8 r6V++efuwuJw5Z4BGuRRtsj1+kGK+h+39Ndm7mdhZX4ebZBXkGF01fs9ZZc80V1bn0Ap MuD2AHzX9J39IrBcFPFWNS0hR9MNYBprheInRk4OWOtCjKbTCh7oJUETvGjixJ9i3GA7 bqBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=1D9LcGBrvXmtnb8G3Nah4wFB3HjRz2Ce8BdaIovSxjY=; b=Rsgk0qQ8TBz5x95Kb9Fu+dyl+SNOMQYD7fscqX+rH78gZeFfixDmbyfrxXlE/bI7Km jYjyxAbLQozQuUTjJ9O4DqyM/DH5bN3sXA0NUYoyFn41WqjBngafhil3OYTvxBpWSvXq 7RKWyqOlx3Aas7Vjlpke8LnC3Z/eT9tMpzbRlIgwMlKXrRUryZ8m91nIfZ91KSBwcQE+ J3RhR80aT3OekaN9QSXfdPVN2uIHAvTiK+dECkNEh/x/afcIp0Xw5or5y0TIRioNNznG hbVIUg8SfAMmUC0p0I2jsy3BU0vUs2B3N2CCfnRx5CyezATcyksZgKDidh58aM1/+6UA /QHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14si10585746ota.142.2020.03.16.02.05.19; Mon, 16 Mar 2020 02:05:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730299AbgCPJFA (ORCPT + 99 others); Mon, 16 Mar 2020 05:05:00 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41304 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730075AbgCPJE7 (ORCPT ); Mon, 16 Mar 2020 05:04:59 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2C50C146F7ECC; Mon, 16 Mar 2020 02:04:59 -0700 (PDT) Date: Mon, 16 Mar 2020 02:04:58 -0700 (PDT) Message-Id: <20200316.020458.1470957653235116686.davem@davemloft.net> To: mkubecek@suse.cz Cc: kuba@kernel.org, netdev@vger.kernel.org, johannes@sipsolutions.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 0/3] ethtool: fail with error if request has unknown flags From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Mar 2020 02:04:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kubecek Date: Sun, 15 Mar 2020 18:17:38 +0100 (CET) > Jakub Kicinski pointed out that if unrecognized flags are set in netlink > header request, kernel shoud fail with an error rather than silently > ignore them so that we have more freedom in future flags semantics. > > To help userspace with handling such errors, inform the client which > flags are supported by kernel. For that purpose, we need to allow > passing cookies as part of extack also in case of error (they can be > only passed on success now). Series applied, thanks Michal.