Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200315121338.251362-1-gch981213@gmail.com> <20200315121338.251362-2-gch981213@gmail.com>
In-Reply-To: <20200315121338.251362-2-gch981213@gmail.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Mon, 16 Mar 2020 10:27:31 +0100
Message-ID: <CAMpxmJU4MOkk7n7OqkEiEbd68qu49ZWywWhx=CAxUFWUgSDsgA@mail.gmail.com>
Subject: Re: [PATCH 1/2] gpio: mmio: introduce BGPIOF_NO_SET_ON_INPUT
To:     Chuanhong Guo <gch981213@gmail.com>
Cc:     linux-gpio <linux-gpio@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Sergio Paracuellos <sergio.paracuellos@gmail.com>,
        =?UTF-8?Q?Ren=C3=A9_van_Dorst?= <opensource@vdorst.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

niedz., 15 mar 2020 o 13:14 Chuanhong Guo <gch981213@gmail.com> napisa=C5=
=82(a):
>
> Some gpio controllers ignores pin value writing when that pin is
> configured as input mode. As a result, bgpio_dir_out should set
> pin to output before configuring pin values or gpio pin values
> can't be set up properly.
> Introduce two variants of bgpio_dir_out: bgpio_dir_out_val_first
> and bgpio_dir_out_dir_first, and assign direction_output according
> to a new flag: BGPIOF_NO_SET_ON_INPUT.
>
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>

Patch applied with Rene's and Sergio's tags.

Bartosz