Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2428616ybh; Mon, 16 Mar 2020 03:02:38 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuH8VfwkKAjlIyxofVY2o6GDkNYKRLqbkBdRjNt2zr7SWK/j58MBdTla9FPlikWtI0oGgho X-Received: by 2002:a54:4584:: with SMTP id z4mr13538865oib.41.1584352958442; Mon, 16 Mar 2020 03:02:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584352958; cv=none; d=google.com; s=arc-20160816; b=nb6R1L4zLLbQF7+BttCbjzFhbSTa6NJMijF1m+RmNlD2hJxOWBsW2/dguTutUFofKc ol/pKTMYB7qjr3rFlVYk9dswTIn7xQWye7ZrYlUae64Q1dAIT50kVt0M+gB1Q+yJYeT1 5VJeicHJqlUnoMZ+MIc4UsE0wf7DVnUaCnrxyTruXlXpfX5AwAH/3nnqEOcn/QN+mZsp Cj3i8Wyy0fP1fyMZSnCbpPIZyhnuUGhwwz1U1dv8qt47WbQtMC/+TdzVkVWkOPkH9owC 3j4NUYG8aKTCgXIcZHEwz1mbJGmSohWrE0G7pqCLAjCTcLZ4KY2IkxQKS1Rz6VSUXh37 oV+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eo6Lnj2n6Gi2H5HDTW21SG50NWmPM4Kj2koyWSbmyHk=; b=KX1tuEeDZiPfxhb4WyWTyPy5ITPLg9MmZJTYgFjs/InB5DnqCsLsoafVc0pKroVtEQ 96P2YYQiI1tfKfKP38u/Hft9LvRylVc1sIokTzNGocD/2ZtjkVa4VvSXM0vjn5BQb6Pq DSifTjT2Gh7QuW38TirHaAEgjovlbwjSEHk4vd0EetChHkSaxMmHKz/MbsdyvFBTPoTT 1BZEKLYhwperZdAVY3xmzFlVqb4gv5tLrMmYVPlLnfsvQ9easv7dGB0qh3k2JTvn1064 P4oxvixM21L+HkDvpgD6sjBIulOc0umFUAjYEbe8LZGNd6zpHhht/oovei1Ep+ZgrvRT ov1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=I1X2Qv5g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p17si11741135ota.232.2020.03.16.03.02.26; Mon, 16 Mar 2020 03:02:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=I1X2Qv5g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730568AbgCPKBz (ORCPT + 99 others); Mon, 16 Mar 2020 06:01:55 -0400 Received: from mail.skyhub.de ([5.9.137.197]:38530 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730558AbgCPKBx (ORCPT ); Mon, 16 Mar 2020 06:01:53 -0400 Received: from zn.tnic (p200300EC2F06AB0069F33882ABEAD541.dip0.t-ipconnect.de [IPv6:2003:ec:2f06:ab00:69f3:3882:abea:d541]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8A0C71EC0CC5; Mon, 16 Mar 2020 11:01:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1584352911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=eo6Lnj2n6Gi2H5HDTW21SG50NWmPM4Kj2koyWSbmyHk=; b=I1X2Qv5g4XkDQqYw0Ot/gY9xVZEMZp9A8BVdRVlbUjBa8yWiz4CCunDQB6i+262pWm/OEO PffIe6vhAaI/VD5qH+s6VO+4I2Pt1n1bcJqAWvrNt/Lw1+ccNpGOW3WyhBmXaiOZiwGL1X A7wVN8cFLSC4qadSNKjbDI20tRyMaNU= Date: Mon, 16 Mar 2020 11:02:02 +0100 From: Borislav Petkov To: Jian-Hong Pan Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Ard Biesheuvel , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , x86@kernel.org, Linux Kernel , linux-efi@vger.kernel.org, Linux Upstreaming Team Subject: Re: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T" Message-ID: <20200316100201.GG26126@zn.tnic> References: <20200312083341.9365-1-jian-hong@endlessm.com> <20200312104643.GA15619@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2020 at 05:17:56PM +0800, Jian-Hong Pan wrote: > But, that will raise another question: Since the original quirk works > for all Acer X514-51T and the quirk cannot be removed for older BIOS. > Why not keep only original matching items for all Acer X514-51T > laptops? What does the "original matching items" mean? > I am not sure which option is better. Any comment? If you mean, "let's not do anything and fix it only when there's really a need to fix anything", then yes, I agree. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette