Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200313031017.71090-1-ling.ma.program@gmail.com>
In-Reply-To: <20200313031017.71090-1-ling.ma.program@gmail.com>
From:   Ling Ma <ling.ma.program@gmail.com>
Date:   Mon, 16 Mar 2020 21:25:42 +0800
Message-ID: <CAOGi=dNniSgkUtJPfaYLAbR+_8DMFdU59mx7hf8Otj_VjDF_dQ@mail.gmail.com>
Subject: Re: [RFC PATCH] locks:Remove spinlock in unshare_files
To:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>
Cc:     "ling.ma" <ling.ml@antfin.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Any comments ?

Thanks
Ling

<ling.ma.program@gmail.com> =E4=BA=8E2020=E5=B9=B43=E6=9C=8813=E6=97=A5=E5=
=91=A8=E4=BA=94 =E4=B8=8A=E5=8D=8811:09=E5=86=99=E9=81=93=EF=BC=9A
>
> From: Ma Ling <ling.ml@antfin.com>
>
> Processor support atomic operation for long/int/short/char type,
> we use the feature to avoid spinlock, which cost hundreds cycles.
>
> Appreciate your comments
> Ling
>
> Signed-off-by: Ma Ling <ling.ml@antfin.com>
> ---
>  kernel/fork.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 60a1295..fe54600 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -3041,9 +3041,7 @@ int unshare_files(struct files_struct **displaced)
>                 return error;
>         }
>         *displaced =3D task->files;
> -       task_lock(task);
> -       task->files =3D copy;
> -       task_unlock(task);
> +       WRITE_ONCE(task->files, copy);
>         return 0;
>  }
>
> --
> 1.8.3.1
>