Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2669043ybh; Mon, 16 Mar 2020 07:33:21 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsqXcVs0ZJGefw752qOIfmQysG9HwPVWPE2Hyb+WBRQwYcRavbtbKkjKPhI5SPchBRbINGN X-Received: by 2002:a05:6830:20c9:: with SMTP id z9mr22811739otq.44.1584369201560; Mon, 16 Mar 2020 07:33:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584369201; cv=none; d=google.com; s=arc-20160816; b=V2FWo8I2KcnOuw/uTpoQnIWmbtQEsS0S1XEzt61fgZQRMbJTeIY6qlXU4T6AI+RZ+d swGiOVhrdWiD1dEWzj/dkO1pQ7K0P5UQYKvDeis2fYGWrKfD/WYrOijvUCoByYDqHbQp oJeSeZxCjgiyFfj5dS8H4DEskbw8NEFFfFQ04mkIuEpdOPHxMLxsHq6TIeemtS1gBSeN xxFR5/mBGA64yrGSSoOmHCduXYbiyhvBSaJKcA1JmiT+dLwUNgPdM6Q+zOuiLTA3dgbc rjRd441+SBg3lrdUJaeCpIHrxLXIQFDD4DTMHWBZnVszU5wNzu6S/hyz8EtCW+YwlIcw G1GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=KaSwaf18FGfEiHIxWjTWNONBE3/JxtbghmgBhaatsqY=; b=T1cfCaiRKcbo1eolqIpXSH9C0EDvcKoXuziUCN+IPqDImgN2mb9s+BJ7d6H6OMg2WM NNvpoQyFj1kYBvLiVN8BomI3eO9oMRLRVjFpDfu4DM+bIXPf7H74QtdXk65mpFxPxYt5 Xt91juph5H4/kZfJnDzSW4kEN8g9l9Ine7QF8ZlGVc18ULFo71cN9gGS5nJ9aXcduiOG +MpJYexTET1ndB6ZBVpYI5z8NfqY9Vxtxo9J1Ilixg0hWTkydHWHxsiJ//lO54wDe6T8 sw8SjMPXg08YjIdvvUB/Ni9KZBgoilyhteaisDQ/SABlX21Y+zjI89RqKsdDKaa312tR GcAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v1si38567otj.204.2020.03.16.07.33.06; Mon, 16 Mar 2020 07:33:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731572AbgCPOc3 (ORCPT + 99 others); Mon, 16 Mar 2020 10:32:29 -0400 Received: from mga09.intel.com ([134.134.136.24]:43228 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731465AbgCPOc3 (ORCPT ); Mon, 16 Mar 2020 10:32:29 -0400 IronPort-SDR: 4D2uMYzM8nmuI8rBDYjMT5yecU2h9BXNT2UcI7D4BqgxAbpW3RydRbZ9dPO+yyWYf9yk9+FhFe t/87Vh3GkJOw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 07:32:28 -0700 IronPort-SDR: CN9to3jq/4ZxD3XYzeg27v4u37TrxQpSX4BMaSP8df9UUzdYmr8MrP8Vira8Tb5aMX1nXcCiPg kw3fstlFotdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,560,1574150400"; d="scan'208";a="443361048" Received: from mylly.fi.intel.com (HELO mylly.fi.intel.com.) ([10.237.72.51]) by fmsmga005.fm.intel.com with ESMTP; 16 Mar 2020 07:32:27 -0700 From: Jarkko Nikula To: linux-kernel@vger.kernel.org Cc: Lee Jones , Andy Shevchenko , Mika Westerberg , Jarkko Nikula Subject: [PATCH] mfd: intel-lpss: Fix Intel Elkhart Lake LPSS I2C input clock Date: Mon, 16 Mar 2020 16:32:24 +0200 Message-Id: <20200316143224.234432-1-jarkko.nikula@linux.intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Intel Elkhart Lake LPSS I2C has 100 MHz input clock instead of 133 MHz that was our preliminary information. This will result slower I2C bus clock when driver calculates its timing parameters in case ACPI tables don't provide them. Slower I2C bus clock is allowed but let's fix this to match with reality. While at it, keep the same default I2C device properties as Intel Broxton since it is not known do they need any update. Signed-off-by: Jarkko Nikula --- For normal development cycle. --- drivers/mfd/intel-lpss-pci.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c index c40a6c7d0cf8..e48f00448551 100644 --- a/drivers/mfd/intel-lpss-pci.c +++ b/drivers/mfd/intel-lpss-pci.c @@ -139,6 +139,11 @@ static const struct intel_lpss_platform_info cnl_i2c_info = { .properties = spt_i2c_properties, }; +static const struct intel_lpss_platform_info ehl_i2c_info = { + .clk_rate = 100000000, + .properties = bxt_i2c_properties, +}; + static const struct pci_device_id intel_lpss_pci_ids[] = { /* CML-LP */ { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info }, @@ -231,15 +236,15 @@ static const struct pci_device_id intel_lpss_pci_ids[] = { { PCI_VDEVICE(INTEL, 0x4b2a), (kernel_ulong_t)&bxt_info }, { PCI_VDEVICE(INTEL, 0x4b2b), (kernel_ulong_t)&bxt_info }, { PCI_VDEVICE(INTEL, 0x4b37), (kernel_ulong_t)&bxt_info }, - { PCI_VDEVICE(INTEL, 0x4b44), (kernel_ulong_t)&bxt_i2c_info }, - { PCI_VDEVICE(INTEL, 0x4b45), (kernel_ulong_t)&bxt_i2c_info }, - { PCI_VDEVICE(INTEL, 0x4b4b), (kernel_ulong_t)&bxt_i2c_info }, - { PCI_VDEVICE(INTEL, 0x4b4c), (kernel_ulong_t)&bxt_i2c_info }, + { PCI_VDEVICE(INTEL, 0x4b44), (kernel_ulong_t)&ehl_i2c_info }, + { PCI_VDEVICE(INTEL, 0x4b45), (kernel_ulong_t)&ehl_i2c_info }, + { PCI_VDEVICE(INTEL, 0x4b4b), (kernel_ulong_t)&ehl_i2c_info }, + { PCI_VDEVICE(INTEL, 0x4b4c), (kernel_ulong_t)&ehl_i2c_info }, { PCI_VDEVICE(INTEL, 0x4b4d), (kernel_ulong_t)&bxt_uart_info }, - { PCI_VDEVICE(INTEL, 0x4b78), (kernel_ulong_t)&bxt_i2c_info }, - { PCI_VDEVICE(INTEL, 0x4b79), (kernel_ulong_t)&bxt_i2c_info }, - { PCI_VDEVICE(INTEL, 0x4b7a), (kernel_ulong_t)&bxt_i2c_info }, - { PCI_VDEVICE(INTEL, 0x4b7b), (kernel_ulong_t)&bxt_i2c_info }, + { PCI_VDEVICE(INTEL, 0x4b78), (kernel_ulong_t)&ehl_i2c_info }, + { PCI_VDEVICE(INTEL, 0x4b79), (kernel_ulong_t)&ehl_i2c_info }, + { PCI_VDEVICE(INTEL, 0x4b7a), (kernel_ulong_t)&ehl_i2c_info }, + { PCI_VDEVICE(INTEL, 0x4b7b), (kernel_ulong_t)&ehl_i2c_info }, /* JSL */ { PCI_VDEVICE(INTEL, 0x4da8), (kernel_ulong_t)&spt_uart_info }, { PCI_VDEVICE(INTEL, 0x4da9), (kernel_ulong_t)&spt_uart_info }, -- 2.25.1