Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2676144ybh; Mon, 16 Mar 2020 07:41:13 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs5+nmJSUuDeoP1/FA+CWpwIFFEhe113eW9LTcAzA3Yn7bImM5G195NdrjrYDG8PLl2M5Ub X-Received: by 2002:a9d:6c99:: with SMTP id c25mr21464766otr.124.1584369673489; Mon, 16 Mar 2020 07:41:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584369673; cv=none; d=google.com; s=arc-20160816; b=VBKFWylwGaXmM7hYbCvARZgKNJE2tsqWU+ChKMP1aGGiMiiUl2f5u53TahjPIGQEPX f2AVjfz4ALinvnL9eVHtYKjP+CRcX5sAk8jQpClsx4tIyZZJRd45aP268wGUde+BcxmI feJfBeG/BZM6mqkkPrdibQw72qeQ0QE9It0qQHDscQHH/bz4RX2aeTVTU91hWqPBXyuc Pn6kb3gBXCW6DbRhJfBcvjNmZw9FmVly7DWz8FpC2hXcybg6r/pn73Zq0uNaQwTLZJSh 9DNmm5PuleA12glwQWgQL8sOcqoyLj151HgdG6190U9DY6QQ1hJFEDpyXVS79cfMlOLl OubQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=Y8CioViJ4ufFl00zd/B+lsyCOak3jCIaiFT3FD8AL0o=; b=zWr+79qekOU8s9QgQ8bFBxDW20RkF4tHcHVxzSafpF7l3xK9kydkwvAwZfKBi6FdEE 1jEZmuQZBcrtclmI8ab4+HoBVZgkHwXnk1kPcR1jpu2Of6IOaoITCTXFgV0Hqisp1vZM oY05oHaEfLYyCWiXsQO1FJlE3QgkSxMJ03/U54OAXX28MgnnMzE/pgG7DDDV1Pi8w67c 9md6aCu6Ur4EA+Fxq7g0bndm/e+0A3j7Lq5USi1zjITEn5COfUpIR8677bAwCmMjthAO 4qkU2W7hn3Y60S1Olddxv1q8/n3U+3uMEz/hi+7ejBdFeNf48OvxjmXGVPqvfASXdahg a8Og== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 9si92623oir.76.2020.03.16.07.41.01; Mon, 16 Mar 2020 07:41:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731657AbgCPOkV (ORCPT + 99 others); Mon, 16 Mar 2020 10:40:21 -0400 Received: from mga05.intel.com ([192.55.52.43]:27653 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731572AbgCPOkU (ORCPT ); Mon, 16 Mar 2020 10:40:20 -0400 IronPort-SDR: vSOJE6taa8UyrczVPRa0OBrubDNnRZXxLfMQExXBS8lGIaOSuw9P0w9YVKXMqoIAhx+OcHUJly wAQzikzp8kiA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 07:40:19 -0700 IronPort-SDR: bMGLbIcmGqh2S0p47k+nya3eXYfE//Kvn6GKONNjdyiMMbyURlK86sVpLFQtzK1qyYp+VzZyIV jVXsvGUxysKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,560,1574150400"; d="scan'208";a="445141887" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006.fm.intel.com with ESMTP; 16 Mar 2020 07:40:18 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jDqui-00A5YZ-Ez; Mon, 16 Mar 2020 16:40:20 +0200 Date: Mon, 16 Mar 2020 16:40:20 +0200 From: Andy Shevchenko To: Martin Kepplinger Cc: dmitry.torokhov@gmail.com, m.felsch@pengutronix.de, mylene.josserand@bootlin.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: edt-ft5x06 - add fw_version debugfs file to read Message-ID: <20200316144020.GN1922688@smile.fi.intel.com> References: <20200316142756.25344-1-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200316142756.25344-1-martin.kepplinger@puri.sm> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2020 at 03:27:56PM +0100, Martin Kepplinger wrote: > Add simple fw_version file in debugfs to read the value from 0xa6 > which is the firmware version. If you switch to regmap I?C API you will get this for free for all defined registers. So, I highly recommend to consider above. -- With Best Regards, Andy Shevchenko