Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2785936ybh; Mon, 16 Mar 2020 09:39:49 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuw33V7R25Uuqqhan30ScIfBESbmozEVkPuXT3QSDQtnByjB6zZVNXW6UGiXT3/jU3kuvvq X-Received: by 2002:a9d:6ad9:: with SMTP id m25mr109059otq.119.1584376789452; Mon, 16 Mar 2020 09:39:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584376789; cv=none; d=google.com; s=arc-20160816; b=H2PjwxVwYM2XaCvnJ06TWUAfTEXmKvMqc/pNBTxN3FBS3KlHgilrcraVOBCXwHqeZN wsdaiuA2dir0Df+G/9x1aE6p3MEpj3SNCuBaKD1KA/GbZ4sHe/M1uFFyhrCTs82kKaQc zoQU8nHJR1u83thWUcr6uIqDvI3Rw+u6PSDiWSWMprkTNVxs0A4zBmhi2yXUy3XBMNNZ uV6raQ2EU5ip1cU9/c0PtXvt3qwg/Jco3y/3+/jlHYlvQcOQeyhXuz999wOLmXxVp4yH VvWktV/Fo6Lj0E9zx6Fa/6ogaSepgTa9noToJslTYmwz8K2P+o1chyHv4TFXhkCKh+XE 1suw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3zQF5bsDQavg+gUvC0pVe0Jc0O5UKaeL1nH0aVPgwnk=; b=dxAOPKOPM0tgN1iIz3L14xVGpbJd9QRiHXktGHFsGnwDnCy2SwwsnVOcU47ek0mNOh KFDFaGw4knui05vgp+B/VUEoczSMMSkA2RXHJj8h7caeEodztwLM1U3Hgd+V+Xpf8ZD9 R0+ADtYS8dQvElKDg/zTc6U3AR/FczgKdZAsf88KrpjRJL1ZsxUAxmj+6I1b57Li4/xd X8gDODn5UMyytdVabaNEk3yEOmtF2Dy9sCRMlk03C7twVP/kPV6NZDtrGBmJWsZ3BszK Gjia62QSreA1otTe3hVGjvsoqdbzF5L0syFbFxaZSnZoW9K4LvfV/RDz2CHUM/YFUWU+ DxnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s199si229962oih.169.2020.03.16.09.39.37; Mon, 16 Mar 2020 09:39:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732198AbgCPQjO (ORCPT + 99 others); Mon, 16 Mar 2020 12:39:14 -0400 Received: from sauhun.de ([88.99.104.3]:54460 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732092AbgCPQjN (ORCPT ); Mon, 16 Mar 2020 12:39:13 -0400 Received: from localhost (p54B334BA.dip0.t-ipconnect.de [84.179.52.186]) by pokefinder.org (Postfix) with ESMTPSA id D625D2C1EFA; Mon, 16 Mar 2020 17:39:11 +0100 (CET) From: Wolfram Sang To: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Wolfram Sang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Francisco Jerez , Dave Airlie , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] drm: encoder_slave: fix refcouting error for modules Date: Mon, 16 Mar 2020 17:39:06 +0100 Message-Id: <20200316163907.13709-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200316163907.13709-1-wsa+renesas@sang-engineering.com> References: <20200316163907.13709-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org module_put() balances try_module_get(), not request_module(). Fix the error path to match that. Fixes: 2066facca4c7 ("drm/kms: slave encoder interface.") Signed-off-by: Wolfram Sang --- drivers/gpu/drm/drm_encoder_slave.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_encoder_slave.c b/drivers/gpu/drm/drm_encoder_slave.c index cf804389f5ec..d50a7884e69e 100644 --- a/drivers/gpu/drm/drm_encoder_slave.c +++ b/drivers/gpu/drm/drm_encoder_slave.c @@ -84,7 +84,7 @@ int drm_i2c_encoder_init(struct drm_device *dev, err = encoder_drv->encoder_init(client, dev, encoder); if (err) - goto fail_unregister; + goto fail_module_put; if (info->platform_data) encoder->slave_funcs->set_config(&encoder->base, @@ -92,9 +92,10 @@ int drm_i2c_encoder_init(struct drm_device *dev, return 0; +fail_module_put: + module_put(module); fail_unregister: i2c_unregister_device(client); - module_put(module); fail: return err; } -- 2.20.1