Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1584172319-24843-3-git-send-email-wcheng@codeaurora.org>
References: <1584172319-24843-1-git-send-email-wcheng@codeaurora.org> <1584172319-24843-3-git-send-email-wcheng@codeaurora.org>
Subject: Re: [PATCH 2/3] clk: qcom: gcc: Add USB3 PIPE clock operations
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Wesley Cheng <wcheng@codeaurora.org>
To:     Wesley Cheng <wcheng@codeaurora.org>, agross@kernel.org,
        bjorn.andersson@linaro.org, mark.rutland@arm.com,
        mturquette@baylibre.com, robh+dt@kernel.org
Date:   Mon, 16 Mar 2020 10:03:14 -0700
Message-ID: <158437819409.88485.6326749791923076608@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Wesley Cheng (2020-03-14 00:51:58)
> Add the USB3 PIPE clock structures, so that the USB driver can
> vote for the GCC to enable/disable it when required.  This clock
> is needed for SSUSB operation.
>=20
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> ---
>  drivers/clk/qcom/gcc-sm8150.c | 26 ++++++++++++++++++++++++++

Can you please combine these two patches and add sm8150 in the subject?

>  1 file changed, 26 insertions(+)
>=20
> diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c
> index d0cd03d..ef98fdc 100644
> --- a/drivers/clk/qcom/gcc-sm8150.c
> +++ b/drivers/clk/qcom/gcc-sm8150.c
> @@ -3172,6 +3172,18 @@ enum {
>         },
>  };
> =20
> +static struct clk_branch gcc_usb3_prim_phy_pipe_clk =3D {
> +       .halt_check =3D BRANCH_HALT_SKIP,
> +       .clkr =3D {
> +               .enable_reg =3D 0xf058,
> +               .enable_mask =3D BIT(0),
> +               .hw.init =3D &(struct clk_init_data){
> +                       .name =3D "gcc_usb3_prim_phy_pipe_clk",
> +                       .ops =3D &clk_branch2_ops,
> +               },
> +       },
> +};
> +
>  static struct clk_branch gcc_usb3_sec_clkref_clk =3D {
>         .halt_reg =3D 0x8c028,
>         .halt_check =3D BRANCH_HALT,
> @@ -3219,6 +3231,18 @@ enum {
>         },
>  };
> =20
> +static struct clk_branch gcc_usb3_sec_phy_pipe_clk =3D {
> +       .halt_check =3D BRANCH_HALT_SKIP,

Sad to see that we'll never resolve this.