Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2844551ybh; Mon, 16 Mar 2020 10:46:55 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsgULJ4k5R9u4ejor8U2EHCEkYqBfQnXfJhu+tEdwTpOz/8tNWf/DB4bodUYGYSziwQDKZZ X-Received: by 2002:a05:6830:1e96:: with SMTP id n22mr306320otr.189.1584380815596; Mon, 16 Mar 2020 10:46:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584380815; cv=none; d=google.com; s=arc-20160816; b=Uu/pTY04huIJR71SUbecFR9UDWuH8Vl/niK/QDB+YqnCxTEYXNsToj2Viv0hcKXmIm qfPxjasDdpHVLlxZC31EWtowZaM/ORWjLGWTnMJLZi0AjcEkuXnA5jR2Iup3a6scfCxI wk79bVXaD6yPlgCy8k2HyDnt+769VP4gNuL9PL8tIniBe40Q/o3PLlCy0kzhlvHHznsj P6m3O4RidwMJk5TKiuWbg0a9lIrz4fDUeO8h4VgLvDG6IlrxnYBToD4In28HT5tSsQhz AAoloQjofit+3zcknETZSAQ2EU88CelPymvNylH3jQYEC5wZ6ZdaqE5reacdyka0qbdk OSYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=MZ44Gn5EfuzZo20COrzajha9x8dIeipe8H4Dxq5Z2HA=; b=DmiP6ZSEsrF/Q5tu+OHQxvvSPxYK3DgAKAwR0I9o8lmpCct1sXLJdk4paECy8zRwJ5 BGW/qwRLHQeDWeX8+yDXqSzUrvSl55fKg9I6VWQYqUGSkK+ty4Tj0xQQGBZ1d5opN++u U7C+CD7i/3F4gXoKhtPbImCN+eOQ2t8au3yFHtAYfY8WRdl6/9avpJL17XiZjylN3HuU TrwUm5FoCIHS7VhOw3VmOHyydMWVOawU1eJYwEym+5z0uEZHk7Ld96ZfjwnlE4RB0g6e q5iVKhd4Tfz7dxnLXTgwFjCIL1IDqGrnZoy2r60jh8N84j9wSzzoN9d9ijj+3q5zF4zg zFyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nD9T9enM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9si257145otk.97.2020.03.16.10.46.43; Mon, 16 Mar 2020 10:46:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nD9T9enM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732068AbgCPRpP (ORCPT + 99 others); Mon, 16 Mar 2020 13:45:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:40646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730437AbgCPRpP (ORCPT ); Mon, 16 Mar 2020 13:45:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 578B520674; Mon, 16 Mar 2020 17:45:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584380714; bh=GfFPEAJ96PQVW/TEMblMoz2dI/DbvaS6Eb3dk99McDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nD9T9enM/fv/bWWZXi6V7pbhTG49uc47IJ1/xmsmAgS1AQPcikbcFZKHqEvacIbRf jdF4G+OAbiJLn0Sz4m0XiSGC1/b3C651R2KMRWZhkzGEBAt40IU69XFEPCwNCOzVDi WCZPo7uxCIaNbOa4Rs6AC6fmjHpao29/kBpgP/F4= Date: Mon, 16 Mar 2020 18:45:02 +0100 From: Greg Kroah-Hartman To: Xiyu Yang Cc: Arnd Bergmann , Xin Tan , Kate Stewart , Allison Randal , Ira Weiny , Thomas Gleixner , linux-kernel@vger.kernel.org, yuanxzhang@fudan.edu.cn, kjlu@umn.edu Subject: Re: [PATCH] VMCI: Fix dereference before NULL-check of context ptr Message-ID: <20200316174502.GA274042@kroah.com> References: <1584375516-10729-1-git-send-email-xiyuyang19@fudan.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584375516-10729-1-git-send-email-xiyuyang19@fudan.edu.cn> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2020 at 12:18:33AM +0800, Xiyu Yang wrote: > A NULL pointer can be returned by vmci_ctx_get(). Thus add a > corresponding check so that a NULL pointer dereference will > be avoided in vmci_ctx_put(). > > Signed-off-by: Xiyu Yang > Signed-off-by: Xin Tan > --- > drivers/misc/vmw_vmci/vmci_queue_pair.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) You sent 2 different patches with the same subject, yet they did different things :( Please fix this up, make them unique, and send a patch series. thanks, greg k-h