Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: vfCLz/9c/Kd22IKCNyrBRWqoEckXRDTJKtP/IRZBPPgOCSKkkRnYjjh9bs1jFEblzDmXCdmMIY
 OP4+VrU72cSg==
IronPort-SDR: 2okYc3O1CkZQl90IZIRmTdtPlRU/7KTyQFVf2t/WeNbMyTWr5ITV6hM5A6Ora06zlIlgJpEpfy
 NHb/syst8c8A==
From:   Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [PATCH 02/10] x86/resctrl: Remove max_delay
To:     James Morse <james.morse@arm.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>
References: <20200214182401.39008-1-james.morse@arm.com>
 <20200214182401.39008-3-james.morse@arm.com>
Message-ID: <0069c11a-772c-23d8-a9f1-c8cb0e2a1c63@intel.com>
Date:   Mon, 16 Mar 2020 11:11:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200214182401.39008-3-james.morse@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi James,

On 2/14/2020 10:23 AM, James Morse wrote:
> max_delay is used by x86's rdt_get_mem_config() as a local variable.

get_mem_config() may be more appropriate since rdt_get_mem_config() does
not exist, __get_mem_config_intel() would be most accurate.

> Remove it, replacing it with a local variable.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Apart from the above ...

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thank you

Reinette