Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: N/AcNTp1JMwxWVFdMhSb/8wCyonMWgXMYYWxzpRmSRVHtEDDbFmFEzodwSmu9hXu6Wukd/koMO
 DzRwWfJpq85w==
IronPort-SDR: 2IJQi9fYHeT34qYhlzLBq+RM3r4ZCPLUmF8prv79tsHZF+o1gw3HuZwMunWAsF1Mw1BA1/n4zc
 REurhr1VDpNw==
From:   Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [PATCH 06/10] x86/resctrl: Use is_closid_match() in more places
To:     James Morse <james.morse@arm.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>
References: <20200214182401.39008-1-james.morse@arm.com>
 <20200214182401.39008-7-james.morse@arm.com>
Message-ID: <fc3b3804-15cf-debf-6bb4-6e9ece92545e@intel.com>
Date:   Mon, 16 Mar 2020 11:15:06 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200214182401.39008-7-james.morse@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi James,

On 2/14/2020 10:23 AM, James Morse wrote:
> rdtgroup_tasks_assigned() and show_rdt_tasks() loop over threads testing
> for a CTRL/MON group match by closid/rmid with the provided rdtgrp.
> Further down the file are helpers to do this, move these further up and
> make use of them here.
> 
> These helpers additionally check for alloc/mon capable. This is harmless
> as rdtgroup_mkdir() tests these capable flags before allowing the config
> directories to be created.
> 
> Signed-off-by: James Morse <james.morse@arm.com>

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thank you

Reinette