Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2876625ybh; Mon, 16 Mar 2020 11:23:20 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtNxCPP7tSlKrkw+Hk2Lr3UenAMzUPh7Np9M+pSjRXR0xfmo9Fm1zZZTtrVrDoXV2f15HnC X-Received: by 2002:a9d:3b76:: with SMTP id z109mr408532otb.335.1584382999976; Mon, 16 Mar 2020 11:23:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584382999; cv=none; d=google.com; s=arc-20160816; b=QSKf53WkvmSbRaoZxBglxos19KhIVZMOBnhrurdmbpP1srImjFJN3vNqFDr1swP1mD VD1+yX/PE63NHSrQQIKbeO4P5AiDzwak9XV773eyQEGVTf4YGMvHEOXj13aN4ar7o0Q0 9KbZu9vxscnvfpc1obAaCFEIfzdo5foPthRs2ajsBosGwXshS1cyEJzkMBI3AVIT63Mr QlKBlZr0tD3+mH8UyfFsKFakDERwcHOVNiUxGXEC9p2LhEY5UFZj1SdhUC9P7YuFIcKy JxTVkeJTLKM+iyV5BTk0heKaXB/FNdydUmsNuReYmfnOoqruUrV6mgt7Tk9iDfLW16he OG6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=DOkg2HYesbm/DvOYb8iVIt2On33s6oF2eyXue+ZWcxI=; b=B8EzE+1ObhQ2Mlolt15Nbn8Mz0f3L2VkdTr2vUsSGBvBCQRgtibg5+Vnzlo1n1riIh ZydGF8Hv+14hzjrTsSU2+JECezZGZC9QhWR4tkdapoWk+uG6oNcVw1V6i+NYO7i6UVtn N8PfsHXQOKNki9Hc8HIPfFed0DhCwPLXFPZLqJRDNF08BNfHI4gChX9LxQriETujHY0y npU/3LLXmmPfR9LoNq1HglOIW4J/k000GolVKiFVUAic1iwTWwyhMjNzstXO5WN+LWLv BYexDQa4PzmFxdwzkYviYfJ6n/XsjSdxphk9EW1uGBwV7Epob6YczdeC0+Xl1Ep+/AMY JdRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="eGzyfmb/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k16si307758oiw.128.2020.03.16.11.23.06; Mon, 16 Mar 2020 11:23:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="eGzyfmb/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732359AbgCPSW1 (ORCPT + 99 others); Mon, 16 Mar 2020 14:22:27 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:35882 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732353AbgCPSW1 (ORCPT ); Mon, 16 Mar 2020 14:22:27 -0400 X-Greylist: delayed 304 seconds by postgrey-1.27 at vger.kernel.org; Mon, 16 Mar 2020 14:22:26 EDT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584382945; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=DOkg2HYesbm/DvOYb8iVIt2On33s6oF2eyXue+ZWcxI=; b=eGzyfmb/2Q1Rw62J3frQjFVoC3dBKdwEbIeB3/C3O/Jw6D4072OLpGsaL2KQjVDfEHWtvH hptaZszIJf0397pkbCzPCQQ+tC5IH/sdtm+ZT1bdr/MaT6L5hQ2Tve4H3jvbJjqa1ZgJxL +VbVqNi70jqAmi9e7xdibuS0HtSiRQg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-SYqmuXwsN1-bEeJ1H2NUmg-1; Mon, 16 Mar 2020 14:16:17 -0400 X-MC-Unique: SYqmuXwsN1-bEeJ1H2NUmg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D320411360A9; Mon, 16 Mar 2020 18:03:14 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A2755D9C9; Mon, 16 Mar 2020 18:03:14 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 02GI3B0b024323; Mon, 16 Mar 2020 19:03:11 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 02GI33u0024322; Mon, 16 Mar 2020 19:03:03 +0100 Date: Mon, 16 Mar 2020 19:03:03 +0100 From: Jakub Jelinek To: Borislav Petkov Cc: Peter Zijlstra , Sergei Trofimovich , linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski , x86@kernel.org Subject: Re: [PATCH] x86: fix early boot crash on gcc-10 Message-ID: <20200316180303.GR2156@tucnak> Reply-To: Jakub Jelinek References: <20200314164451.346497-1-slyfox@gentoo.org> <20200316130414.GC12561@hirez.programming.kicks-ass.net> <20200316132648.GM2156@tucnak> <20200316134234.GE12561@hirez.programming.kicks-ass.net> <20200316175450.GO26126@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316175450.GO26126@zn.tnic> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2020 at 06:54:50PM +0100, Borislav Petkov wrote: > So having a way to state "do not add stack canary checking to this > particular function" would be optimal. And since you already have the > "stack_protect" function attribute I figure adding a "no_stack_protect" > one should be easy... Easy, but a waste when GCC already has the optimize attribute that can handle also ~450 other options that are per-function rather than per-TU. Jakub