Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200316090021.52148-1-pmalani@chromium.org> <20200316090021.52148-4-pmalani@chromium.org>
In-Reply-To: <20200316090021.52148-4-pmalani@chromium.org>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Mon, 16 Mar 2020 13:08:11 -0700
Message-ID: <CACeCKadfezCCAa67p71Dqf2WUR8szLO45xzPq4XxFG53S-Y5fQ@mail.gmail.com>
Subject: Re: [PATCH v5 3/4] platform/chrome: typec: Get PD_CONTROL cmd version
To:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

My apologies, missed adding Heikki.

On Mon, Mar 16, 2020 at 2:01 AM Prashant Malani <pmalani@chromium.org> wrote:
>
> Query the EC to determine the version number of the PD_CONTROL
> command which is supported by the EC. Also store this value in the Type
> C data struct since it will be used to determine how to parse the
> response to queries for port information from the EC.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
>
> Changes in v5:
> - No changes.
>
> Changes in v4:
> - No changes
>
> Changes in v3:
> - Moved if statement check in the end of probe() from this patch to a
>   previous patch.
>
> Changes in v2:
> - No changes.
>
>  drivers/platform/chrome/cros_ec_typec.c | 32 +++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 02e6d5cbbbf7a..9f692eb78b322 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -21,6 +21,7 @@ struct cros_typec_data {
>         struct device *dev;
>         struct cros_ec_device *ec;
>         int num_ports;
> +       unsigned int cmd_ver;
>         /* Array of ports, indexed by port number. */
>         struct typec_port *ports[EC_USB_PD_MAX_PORTS];
>         /* Initial capabilities for each port. */
> @@ -171,6 +172,31 @@ static int cros_typec_ec_command(struct cros_typec_data *typec,
>         return ret;
>  }
>
> +static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
> +{
> +       struct ec_params_get_cmd_versions_v1 req_v1;
> +       struct ec_response_get_cmd_versions resp;
> +       int ret;
> +
> +       /* We're interested in the PD control command version. */
> +       req_v1.cmd = EC_CMD_USB_PD_CONTROL;
> +       ret = cros_typec_ec_command(typec, 1, EC_CMD_GET_CMD_VERSIONS,
> +                                   &req_v1, sizeof(req_v1), &resp,
> +                                   sizeof(resp));
> +       if (ret < 0)
> +               return ret;
> +
> +       if (resp.version_mask & EC_VER_MASK(1))
> +               typec->cmd_ver = 1;
> +       else
> +               typec->cmd_ver = 0;
> +
> +       dev_dbg(typec->dev, "PD Control has version mask 0x%hhx\n",
> +               typec->cmd_ver);
> +
> +       return 0;
> +}
> +
>  #ifdef CONFIG_ACPI
>  static const struct acpi_device_id cros_typec_acpi_id[] = {
>         { "GOOG0014", 0 },
> @@ -202,6 +228,12 @@ static int cros_typec_probe(struct platform_device *pdev)
>         typec->ec = dev_get_drvdata(pdev->dev.parent);
>         platform_set_drvdata(pdev, typec);
>
> +       ret = cros_typec_get_cmd_version(typec);
> +       if (ret < 0) {
> +               dev_err(dev, "failed to get PD command version info\n");
> +               return ret;
> +       }
> +
>         ret = cros_typec_ec_command(typec, 0, EC_CMD_USB_PD_PORTS, NULL, 0,
>                                     &resp, sizeof(resp));
>         if (ret < 0)
> --
> 2.25.1.481.gfbce0eb801-goog
>