Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp3132943ybh; Mon, 16 Mar 2020 16:39:43 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvTNggr3Pjz4UjPQQ7MGJWEdGuzugvHIiJ7tvMgoJchMsudaMYOKRNmpbeZlLpHu7Cnbb3N X-Received: by 2002:a9d:64d4:: with SMTP id n20mr1353206otl.193.1584401983122; Mon, 16 Mar 2020 16:39:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584401983; cv=none; d=google.com; s=arc-20160816; b=VJqL7XomzJT2CEDRiE7KFds2ZPqmOUUnpXIfCdcdD48cW+u+v44caX0r0Gz8AfOPwF kTrZ9pSJHvnIV8b2MWIle4Ymzx9f7Uhi+Uy8XFjRaHq1Jtmr6RJPkm2gXBcjCbrYVnRv g8DATB72QlYMPyTBkUmNYfE98p3/Z6YTzSCzuMHTqg5bhkC8n2ZsXhAeqZ12VaYh32h3 7Nl2E1Ksxje8hRn7Ve/1ffCyA67YleczpsNAIZjhAzmAV4ZxDrYi9oF0WyQqn03rYvrP cQZDOrMMJa+8M0TfgyIWg1XcqEr9YEEpCNvF2Sk6I1slcciaOZonSYlZ8mXc+5PukR/D UqJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nOl1AKXgStV93i06X/WL0ilGV0db2i3MJV2zuTRnHiE=; b=YVrh4aGH93va+XtiIq6Mb77IU7dPy1207sPvLv2Lp9YovUT4/r8qTLqog5PzbxcRX0 p1d/s1NQNIIKgeAet9HIHCZL7TL+pLnG1FINMe7q8Gw1JdbqyuiMBNx3o6OeDH9OOC9g oukrFECN6frQ3A89PnmxLBZpO0YDYlIEkBgIPQLxE2pDdFlkYbEEBILevuXQiOZ7ICCJ SBY70aOwD9gwkLy7JEC5MFK/NOmEiC20y78t0cDSV1fVxTKBYqmAmd1ybFhUH087V2X2 dk9w/VvmFH3cT8XOU4hMj8uEQ6RDOYlUmUWtMKQV4bffhZAWKTBu2ms6p0uO43ocOet8 3THQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rQLOqbAG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x63si771592oia.101.2020.03.16.16.39.28; Mon, 16 Mar 2020 16:39:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rQLOqbAG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733006AbgCPXjA (ORCPT + 99 others); Mon, 16 Mar 2020 19:39:00 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50813 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732982AbgCPXi5 (ORCPT ); Mon, 16 Mar 2020 19:38:57 -0400 Received: by mail-wm1-f68.google.com with SMTP id z13so3508909wml.0; Mon, 16 Mar 2020 16:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nOl1AKXgStV93i06X/WL0ilGV0db2i3MJV2zuTRnHiE=; b=rQLOqbAGyKRVc3FWPBnLv/9m0l8mWZUgw2umajD/W+V79krhzZBswsGmABz/TIeZFi taFfKcN3pov/T3iBXclZ08BDJZxNdNB1GP2GWS/OLjSMGgGv0JPWunqrv3OjYwmeAK2z I3mZGU1QBtQ/dLdW247fUjf9BxHkg+ksCqZAU0g77Yoxfk7aBR4Ld6UUe7eu0YYz91Oi ytp1L40qadUprCb2+iYbKoSM6P1wfLSvXiS5FL2LVI5cuvL3NtmIeiiuPADeL3TjTVAt uKSZfRGbKziV2rpS7XolejYRz89TOEJO+udQJo81kRT1uw5bNLJqX1xoZ5xyuc4F/6Oa 6Okg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nOl1AKXgStV93i06X/WL0ilGV0db2i3MJV2zuTRnHiE=; b=tIUvA1O2RHzQEnQwHbJg2+VxghlJaZUFr9MD97iIzeHF4otvjA1oet9UaxNjU2S2A4 i7VTrgd1nUtwKj9VyGf1qllcXmAmdg5cAyCFicgJJDd7gl3GGe1Ru2Sd1fhnUEB0TYi7 t/v8SMtSt6MdKVORFATFNrXzPIjBrymnT6PPSk3s4MPufyxuo6RPGJes/OVwdVwrHJXq XHJvHPEsoaTSwAO4L4PVF7iPC5STMzFvzFu3E1z1UuylWXSYSIZlYvrVpUeyTaHZ8waF mgr7vJRsA9tUtD6anWoSgGGQm46euoXizExyPuCmB8bzG8dgSm6aZZSMGsD5Tnyxpdh5 9iPQ== X-Gm-Message-State: ANhLgQ3aTTkAbUfceasyPTBoex8oC+A++eRRyq23qyLiTES48HpCTg9m wWq2qj/DgePfX/SJ0WIFyCiMstEwlw== X-Received: by 2002:a1c:2c8a:: with SMTP id s132mr1460869wms.22.1584401934867; Mon, 16 Mar 2020 16:38:54 -0700 (PDT) Received: from localhost.localdomain (host-92-23-82-35.as13285.net. [92.23.82.35]) by smtp.googlemail.com with ESMTPSA id i9sm1510495wmd.37.2020.03.16.16.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 16:38:54 -0700 (PDT) From: Jules Irenge To: boqun.feng@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Viro Subject: [PATCH 6/6] fs: add missing annotation for pin_kill() Date: Mon, 16 Mar 2020 23:38:04 +0000 Message-Id: <20200316233804.96657-7-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200316233804.96657-1-jbi.octave@gmail.com> References: <0/6> <20200316233804.96657-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at pin_kill() warning: context imbalance in pin_kill() - unexpected unlock The root cause is the missing annotation at pin_kill() Add the missing __releases(RCU) Signed-off-by: Jules Irenge --- fs/fs_pin.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/fs_pin.c b/fs/fs_pin.c index 47ef3c71ce90..ee57700740df 100644 --- a/fs/fs_pin.c +++ b/fs/fs_pin.c @@ -28,6 +28,7 @@ void pin_insert(struct fs_pin *pin, struct vfsmount *m) } void pin_kill(struct fs_pin *p) + __releases(RCU) { wait_queue_entry_t wait; -- 2.24.1