Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp3171333ybh; Mon, 16 Mar 2020 17:30:02 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtEriZ5eWSt12v4CrMdVtq1maFzxxIzCQ72NPBJMHxs6YvFRL4aBPUeKKhxdEfqvYHalS6o X-Received: by 2002:a9d:2963:: with SMTP id d90mr1506200otb.149.1584405002432; Mon, 16 Mar 2020 17:30:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584405002; cv=none; d=google.com; s=arc-20160816; b=rfSRDpks5os/oRWIoQeK9bgR3zx5FDEyu+crwRojKYZ4GxZIUzLY9vDP14w+sN/bYJ qi+YdBtXd+WCeukdxANJNfWhlbQIpFL+3UedXotB5z/zsPmHxZGMXFtOKlyg8IPyyhR4 9JkrmPk7sfRBBGl1GVqTYvqWrl8aKbU6r1MIw0gXlZ3u0DWgG4JCIp0XslG4CrxqHPZh JbF/UKHytweNKA1ZqbgGD8nMYdeLBJTulLchQY/IxnvI8o1BEiDJ7xauglPqr1yl/2UR ko2T7WlZG5V6Recl5YENU0MotENcL4NiRU54V8bckfYDNiVfZ0VRgAjQzbz6HLmaFXfd Yrbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :references:subject:cc:to:mime-version:user-agent:from:date :message-id; bh=dPBeOOnKr7AzNUyDlaFQQhnSfG3I02X9MbJZHoELVHc=; b=Jtynr40eAjoK19jD7xOlXqU761+4rIuNyy5g+UPBuCLaOiLaaC8CsKN36wMYxQKU6i T2//ojL1IFEx4eA4e0DnvMD8Y5g3SlwlhPFEq+tAVVC7CbSTU7sev2kXNL8Qq4RsLA69 78pTQgUMhQ7ltJxMP821PgYsM/EnhBVlwNJm9QQ1jS+D4dS+l+y9lyNCk0lOXnQQVi5s oTtDQY31xL5OCxMm3Igly9E5ABRmOmpvXfjdxGsW2PoCeXiz17bbzbFj9pJ515W3Eujs ccbbzX3sxC/TnFid6EkzXvzdHRIlL6wKS6taDJc26R8BGjWYyUQitQQIZWw2OBwg0Bhw 45aQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d19si799212otq.162.2020.03.16.17.29.49; Mon, 16 Mar 2020 17:30:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733181AbgCQA0D (ORCPT + 99 others); Mon, 16 Mar 2020 20:26:03 -0400 Received: from regular1.263xmail.com ([211.150.70.206]:50522 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733159AbgCQA0C (ORCPT ); Mon, 16 Mar 2020 20:26:02 -0400 X-Greylist: delayed 456 seconds by postgrey-1.27 at vger.kernel.org; Mon, 16 Mar 2020 20:26:02 EDT Received: from localhost (unknown [192.168.167.13]) by regular1.263xmail.com (Postfix) with ESMTP id 3ECB0229; Tue, 17 Mar 2020 08:18:17 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 Received: from [172.16.22.134] (unknown [103.29.142.67]) by smtp.263.net (postfix) whith ESMTP id P30134T140168394696448S1584404291121062_; Tue, 17 Mar 2020 08:18:17 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: jeffy.chen@rock-chips.com X-SENDER: cjf@rock-chips.com X-LOGIN-NAME: jeffy.chen@rock-chips.com X-FST-TO: sboyd@kernel.org X-SENDER-IP: 103.29.142.67 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 X-System-Flag: 0 Message-ID: <5E701742.60706@rock-chips.com> Date: Tue, 17 Mar 2020 08:18:10 +0800 From: JeffyChen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Stephen Boyd , Naresh Kamboju , linux-clk@vger.kernel.org, open list , Greg Kroah-Hartman CC: Arnd Bergmann , lkft-triage@lists.linaro.org, Anders Roxell , mturquette@baylibre.com, Daniel Lezcano , Basil Eljuse Subject: Re: WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:4156 __clk_put+0xfc/0x130 References: <158438237211.88485.8872594504996170580@swboyd.mtv.corp.google.com> In-Reply-To: <158438237211.88485.8872594504996170580@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, On 03/17/2020 02:12 AM, Stephen Boyd wrote: > Looks like Greg picked up this patch[1] as commit b8fe128dad8f > ("arch_topology: Adjust initial CPU capacities with current freq") from > the list. Not sure it's correct though and I haven't looked in any more > detail. At least, not calling clk_put() unless it is a valid pointer > will work to quiet this warning. > > [1] https://lore.kernel.org/r/20200113034815.25924-1-jeffy.chen@rock-chips.com > Sorry, i made a stupid mistake... Sending the fix now, thanks for checking that.