Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp3445791ybh; Mon, 16 Mar 2020 23:51:47 -0700 (PDT) X-Google-Smtp-Source: ADFU+vu2cuE2p7FXx/stuHWpKuRF/aNSlkX3DkpAbgy/mFNLs/t8XgytnQT4NRteNHWkrD99NwM4 X-Received: by 2002:a9d:d36:: with SMTP id 51mr2622262oti.308.1584427907204; Mon, 16 Mar 2020 23:51:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584427907; cv=none; d=google.com; s=arc-20160816; b=r5ROhaf1DQt/3/56Dn/QWRpxZ7U1Uh8U6swEPmyrFY1LMa2hgVNAiKfFjS4HRHAfN/ xVlPv+K2d6wlydInp4RDn68EZYA/KCGSev4pXSXrYqYhNOzRfmVltS4IETvf9IIlir6+ le3iZRnVxd5zCEvWXqQNLQH4Q4fmJZGDMSrXoZEFXrSQO1QkpMEu2XiQ/zzYMpHzmReu KmC1qY9GNOPjSS6LuAcRl089ysaapeLLL1gVxaSIKCPO4q2ML27b5NptREtdC5wbVdhN LX8O4F8KhDnBVYXXUKZ6abhJ3hVkP4l1qsC8/56NMV7VSy0lOMie0bCbGtCEvllCrnHe SfnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject; bh=ih1ZWfjvc2IeHxv5u4MSOFecsWNXYqRaWLbDmOz25Yc=; b=fzeE6mr+8cb4i80okqJEX9z+3MxFt9uvKJ1dlyNegipfhQuI4Phfy0oltrgsrbN5Q8 ZwANMIZNdVNs3JdT32rNRSFZu1VavDmQJsv22kUjN+y0Z9pfwq8IT52lI9zJGB0x9moI EFDSStJAlS/CoaQ26YQVRICTGS+2NVv8L4YAbg+oHTvtMnlLphSZUiqOpABt9f+UXxJI uCQpHtqcOjlDtsqcRWAh+aE81BxInY4l/0YuHQloHKXoNMwjIgKlJMYSrmnEiYyD+brw 6b0eCHQl00Ep9IghDKImLeS+GbbSZCT39geOh1NiKmGcNFlMYROQWj4RQtEjVu5jBbpM CTag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x26si1317307otp.61.2020.03.16.23.51.34; Mon, 16 Mar 2020 23:51:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725868AbgCQGut (ORCPT + 99 others); Tue, 17 Mar 2020 02:50:49 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:15952 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725536AbgCQGus (ORCPT ); Tue, 17 Mar 2020 02:50:48 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02H6Z5Lr029838 for ; Tue, 17 Mar 2020 02:50:46 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ytb4u0rkk-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 17 Mar 2020 02:50:46 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Mar 2020 06:50:44 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 17 Mar 2020 06:50:39 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02H6ocFu58261578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Mar 2020 06:50:38 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C675AE051; Tue, 17 Mar 2020 06:50:38 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 12600AE045; Tue, 17 Mar 2020 06:50:31 +0000 (GMT) Received: from localhost.localdomain (unknown [9.85.82.238]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 17 Mar 2020 06:50:30 +0000 (GMT) Subject: Re: [RFC 00/11] perf: Enhancing perf to export processor hazard information To: Kim Phillips , Ravi Bangoria Cc: Stephane Eranian , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, LKML , Michael Ellerman , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Andi Kleen , "Liang, Kan" , Alexey Budankov , yao.jin@linux.intel.com, Robert Richter References: <20200302052355.36365-1-ravi.bangoria@linux.ibm.com> <20200302101332.GS18400@hirez.programming.kicks-ass.net> <2550ec4d-a015-4625-ca24-ff10632dbe2e@linux.ibm.com> <8a4d966c-acc9-b2b7-8ab7-027aefab201c@linux.ibm.com> From: maddy Date: Tue, 17 Mar 2020 12:20:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 20031706-0008-0000-0000-0000035E89A2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20031706-0009-0000-0000-00004A7FDF2B Message-Id: <0c5e94a3-e86e-f7cb-d668-d542b3a8ae29@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.645 definitions=2020-03-17_01:2020-03-12,2020-03-17 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003170026 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/13/20 4:08 AM, Kim Phillips wrote: > On 3/11/20 11:00 AM, Ravi Bangoria wrote: >> Hi Kim, > Hi Ravi, > >> On 3/6/20 3:36 AM, Kim Phillips wrote: >>>> On 3/3/20 3:55 AM, Kim Phillips wrote: >>>>> On 3/2/20 2:21 PM, Stephane Eranian wrote: >>>>>> On Mon, Mar 2, 2020 at 2:13 AM Peter Zijlstra wrote: >>>>>>> On Mon, Mar 02, 2020 at 10:53:44AM +0530, Ravi Bangoria wrote: >>>>>>>> Modern processors export such hazard data in Performance >>>>>>>> Monitoring Unit (PMU) registers. Ex, 'Sampled Instruction Event >>>>>>>> Register' on IBM PowerPC[1][2] and 'Instruction-Based Sampling' on >>>>>>>> AMD[3] provides similar information. >>>>>>>> >>>>>>>> Implementation detail: >>>>>>>> >>>>>>>> A new sample_type called PERF_SAMPLE_PIPELINE_HAZ is introduced. >>>>>>>> If it's set, kernel converts arch specific hazard information >>>>>>>> into generic format: >>>>>>>> >>>>>>>>     struct perf_pipeline_haz_data { >>>>>>>>            /* Instruction/Opcode type: Load, Store, Branch .... */ >>>>>>>>            __u8    itype; >>>>>>>>            /* Instruction Cache source */ >>>>>>>>            __u8    icache; >>>>>>>>            /* Instruction suffered hazard in pipeline stage */ >>>>>>>>            __u8    hazard_stage; >>>>>>>>            /* Hazard reason */ >>>>>>>>            __u8    hazard_reason; >>>>>>>>            /* Instruction suffered stall in pipeline stage */ >>>>>>>>            __u8    stall_stage; >>>>>>>>            /* Stall reason */ >>>>>>>>            __u8    stall_reason; >>>>>>>>            __u16   pad; >>>>>>>>     }; >>>>>>> Kim, does this format indeed work for AMD IBS? >>>>> It's not really 1:1, we don't have these separations of stages >>>>> and reasons, for example: we have missed in L2 cache, for example. >>>>> So IBS output is flatter, with more cycle latency figures than >>>>> IBM's AFAICT. >>>> AMD IBS captures pipeline latency data incase Fetch sampling like the >>>> Fetch latency, tag to retire latency, completion to retire latency and >>>> so on. Yes, Ops sampling do provide more data on load/store centric >>>> information. But it also captures more detailed data for Branch instructions. >>>> And we also looked at ARM SPE, which also captures more details pipeline >>>> data and latency information. >>>> >>>>>> Personally, I don't like the term hazard. This is too IBM Power >>>>>> specific. We need to find a better term, maybe stall or penalty. >>>>> Right, IBS doesn't have a filter to only count stalled or otherwise >>>>> bad events.  IBS' PPR descriptions has one occurrence of the >>>>> word stall, and no penalty.  The way I read IBS is it's just >>>>> reporting more sample data than just the precise IP: things like >>>>> hits, misses, cycle latencies, addresses, types, etc., so words >>>>> like 'extended', or the 'auxiliary' already used today even >>>>> are more appropriate for IBS, although I'm the last person to >>>>> bikeshed. >>>> We are thinking of using "pipeline" word instead of Hazard. >>> Hm, the word 'pipeline' occurs 0 times in IBS documentation. >> NP. We thought pipeline is generic hw term so we proposed "pipeline" >> word. We are open to term which can be generic enough. >> >>> I realize there are a couple of core pipeline-specific pieces >>> of information coming out of it, but the vast majority >>> are addresses, latencies of various components in the memory >>> hierarchy, and various component hit/miss bits. >> Yes. we should capture core pipeline specific details. For example, >> IBS generates Branch unit information(IbsOpData1) and Icahce related >> data(IbsFetchCtl) which is something that shouldn't be extended as >> part of perf-mem, IMO. > Sure, IBS Op-side output is more 'perf mem' friendly, and so it > should populate perf_mem_data_src fields, just like POWER9 can: > > union perf_mem_data_src { > ... > __u64 mem_rsvd:24, > mem_snoopx:2, /* snoop mode, ext */ > mem_remote:1, /* remote */ > mem_lvl_num:4, /* memory hierarchy level number */ > mem_dtlb:7, /* tlb access */ > mem_lock:2, /* lock instr */ > mem_snoop:5, /* snoop mode */ > mem_lvl:14, /* memory hierarchy level */ > mem_op:5; /* type of opcode */ > > > E.g., SIER[LDST] SIER[A_XLATE_SRC] can be used to populate > mem_lvl[_num], SIER_TYPE can be used to populate 'mem_op', > 'mem_lock', and the Reload Bus Source Encoding bits can > be used to populate mem_snoop, right? Hi Kim, Yes. We do expose these data as part of perf-mem for POWER. > For IBS, I see PERF_SAMPLE_ADDR and PERF_SAMPLE_PHYS_ADDR can be > used for the ld/st target addresses, too. > >>> What's needed here is a vendor-specific extended >>> sample information that all these technologies gather, >>> of which things like e.g., 'L1 TLB cycle latency' we >>> all should have in common. >> Yes. We will include fields to capture the latency cycles (like Issue >> latency, Instruction completion latency etc..) along with other pipeline >> details in the proposed structure. > Latency figures are just an example, and from what I > can tell, struct perf_sample_data already has a 'weight' member, > used with PERF_SAMPLE_WEIGHT, that is used by intel-pt to > transfer memory access latency figures. Granted, that's > a bad name given all other vendors don't call latency > 'weight'. > > I didn't see any latency figures coming out of POWER9, > and do not expect this patchseries to implement those > of other vendors, e.g., AMD's IBS; leave each vendor > to amend perf to suit their own h/w output please. Reference structure proposed in this patchset did not have members to capture latency info for that exact reason. But idea here is to abstract  as vendor specific as possible. So if we include u16 array, then this format can also capture data from IBS since it provides few latency details. > > My main point there, however, was that each vendor should > use streamlined record-level code to just copy the data > in the proprietary format that their hardware produces, > and then then perf tooling can synthesize the events > from the raw data at report/script/etc. time. > >>> I'm not sure why a new PERF_SAMPLE_PIPELINE_HAZ is needed >>> either.  Can we use PERF_SAMPLE_AUX instead? >> We took a look at PERF_SAMPLE_AUX. IIUC, PERF_SAMPLE_AUX is intended when >> large volume of data needs to be captured as part of perf.data without >> frequent PMIs. But proposed type is to address the capture of pipeline > SAMPLE_AUX shouldn't care whether the volume is large, or how frequent > PMIs are, even though it may be used in those environments. > >> information on each sample using PMI at periodic intervals. Hence proposing >> PERF_SAMPLE_PIPELINE_HAZ. > And that's fine for any extra bits that POWER9 has to convey > to its users beyond things already represented by other sample > types like PERF_SAMPLE_DATA_SRC, but the capturing of both POWER9 > and other vendor e.g., AMD IBS data can be made vendor-independent > at record time by using SAMPLE_AUX, or SAMPLE_RAW even, which is > what IBS currently uses. My bad. Not sure what you mean by this. We are trying to abstract as much vendor specific data as possible with this (like perf-mem). Maddy > >>>  Take a look at >>> commit 98dcf14d7f9c "perf tools: Add kernel AUX area sampling >>> definitions".  The sample identifier can be used to determine >>> which vendor's sampling IP's data is in it, and events can >>> be recorded just by copying the content of the SIER, etc. >>> registers, and then events get synthesized from the aux >>> sample at report/inject/annotate etc. time.  This allows >>> for less sample recording overhead, and moves all the vendor >>> specific decoding and common event conversions for userspace >>> to figure out. >> When AUX buffer data is structured, tool side changes added to present the >> pipeline data can be re-used. > Not sure I understand: AUX data would be structured on > each vendor's raw h/w register formats. > > Thanks, > > Kim > >>>>>> Also worth considering is the support of ARM SPE (Statistical >>>>>> Profiling Extension) which is their version of IBS. >>>>>> Whatever gets added need to cover all three with no limitations. >>>>> I thought Intel's various LBR, PEBS, and PT supported providing >>>>> similar sample data in perf already, like with perf mem/c2c? >>>> perf-mem is more of data centric in my opinion. It is more towards >>>> memory profiling. So proposal here is to expose pipeline related >>>> details like stalls and latencies. >>> Like I said, I don't see it that way, I see it as "any particular >>> vendor's event's extended details', and these pipeline details >>> have overlap with existing infrastructure within perf, e.g., L2 >>> cache misses. >>> >>> Kim >>>