Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp3519326ybh;
        Tue, 17 Mar 2020 01:29:07 -0700 (PDT)
X-Google-Smtp-Source: ADFU+vuLL6Ggt+oKqdFLmKXrqKz69rfviIIvlyPmfrZbxepjF7L1MOIQ3Aho+HHnH3vMCpKc+gs8
X-Received: by 2002:aca:344:: with SMTP id 65mr2586423oid.126.1584433747427;
        Tue, 17 Mar 2020 01:29:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1584433747; cv=none;
        d=google.com; s=arc-20160816;
        b=VTv8WX6/pFuyXW/DBV6UCRkAWo4+zjQmGTPT1U2VjjeNGsHvT74CPJ6M8PguShDOQC
         vmS1RXG8CO8RMSF1vAQJ8aLieTgIgdUwD9uUplIWxLhls+NkvBIUtFblFzOGtTsE9JHJ
         ZDPoSmDaRGpqo1duV2BTC+MYyaQtVEMyr6/0IO2xk8Sw/+6Pej0ZRlDVim2cTtcT5B7C
         DZMh7+OUSPsdkadrma0pouQwEKtcBD9Wi5SyoHtcQNT9XHCjhHKncm3XaorMgQUXz9mZ
         2iUuQRTIX+9BJ8vFIUuxivK81s5O77844rkt6zLofisAo6iIJg80HUPWw895IlYYy0rP
         195Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:mime-version:message-id:date:references
         :organization:in-reply-to:subject:cc:to:from:ironport-sdr
         :ironport-sdr;
        bh=ctfZBEzOzyZxRdShjTxa+q1eXoaGAlVl/wsQgoRpIFY=;
        b=ZtICUG/nI1R+YR+kcR4/Apf0M0v/tnKmZBMLKrApMIQSytw8Zx5OyRSTfDzf926nR0
         Oe2OxKCntX9KukJAiWCeu8WdPt4jJpVeeTSVoWFDwNYdB3+KTIqytV26+rYOwFHSVC11
         +ZYIFVr3leFvzN7gUt+U2Y+/Vgn1rr1V8oi2mfwQb5qawibRcgqaNHwMoN/2VuRYLvfC
         4Pl8w5K1Nii1rrpAdbkxcyc3aWXefUVqyxtlLc5YhD0WHSKIc0XvJCKhDpyknbnbJFPF
         G2PHtOokeG2DWIx5tEYEx/6rhlnTZGaTB+J6ncKI04EmfxxkkmDblm2qzk0seMRdbOv4
         08tQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id v130si1387950oib.115.2020.03.17.01.28.55;
        Tue, 17 Mar 2020 01:29:07 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726187AbgCQI2c (ORCPT <rfc822;xc.haze2010@gmail.com>
        + 99 others); Tue, 17 Mar 2020 04:28:32 -0400
Received: from mga06.intel.com ([134.134.136.31]:15232 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725868AbgCQI2b (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Mar 2020 04:28:31 -0400
IronPort-SDR: L+wOpw7Il/Ya190YYDNNlQMOn7UllIZCQ8dXXTUlYPe3aOJvRLEPp+nCvVvfVW8o1pDmZk+WWu
 1O6JNQhljKXA==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 01:28:31 -0700
IronPort-SDR: healM5eFWf/Kw6gBx4FVqQaJZugrClmjQKDXhbzYDs3BBjEOxoAnAMbVR9ke5InzTm6fiaOhDa
 EEpQ9MKjRDYw==
X-IronPort-AV: E=Sophos;i="5.70,563,1574150400"; 
   d="scan'208";a="390985809"
Received: from bquerbac-mobl1.amr.corp.intel.com (HELO localhost) ([10.135.40.52])
  by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 01:28:28 -0700
From:   "Patrick Ohly" <patrick.ohly@intel.com>
To:     Vivek Goyal <vgoyal@redhat.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvdimm@lists.01.org, virtio-fs@redhat.com, miklos@szeredi.hu,
        stefanha@redhat.com, dgilbert@redhat.com, mst@redhat.com
Subject: Re: [PATCH 00/20] virtiofs: Add DAX support
In-Reply-To: <20200316130234.GA4013@redhat.com>
Organization: Intel GmbH, Dornacher Strasse 1, D-85622 Feldkirchen/Munich
References: <20200304165845.3081-1-vgoyal@redhat.com> <yrjh1rpzggg4.fsf@pohly-mobl1.fritz.box> <20200316130234.GA4013@redhat.com>
Date:   Tue, 17 Mar 2020 09:28:26 +0100
Message-ID: <yrjhlfnzcrmd.fsf@pohly-mobl1.fritz.box>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Vivek Goyal <vgoyal@redhat.com> writes:
> We expect users will issue fsync/msync like a regular filesystem to
> make changes persistent. So in that aspect, rejecting MAP_SYNC
> makes sense. I will test and see if current code is rejecting MAP_SYNC
> or not.

Last time I checked, it did. Here's the test program that I wrote for
that:
https://github.com/intel/pmem-csi/blob/ee3200794a1ade49a02df6f359a134115b409e90/test/cmd/pmem-dax-check/main.go

-- 
Best Regards

Patrick Ohly