Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp3523863ybh; Tue, 17 Mar 2020 01:34:54 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsouEW1TkFajXYmYbBQEPmqpVBVLy5r6cXBmGmjcOMHbNzxJ4cE/3g9gxiy7U6rp1B+RgzA X-Received: by 2002:a05:6830:13d8:: with SMTP id e24mr527629otq.328.1584434094343; Tue, 17 Mar 2020 01:34:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584434094; cv=none; d=google.com; s=arc-20160816; b=ObuPGYlAiwW563VQLdiAI6I1AFMNbtpDC1Qy8eohKmtm6MDyMyW5IsZfRIM0YdG1f1 Rlz5Se3PTWSYZcKtIhK+CiVpYyYxOo2+KeaDn31ZGNcG3FvHFcov/nfV2B2eGxdpfxuH LofAJPsKz4ze0vbhKA/VDlQLzSxznGtYZmeKJarRJIn7LKVT12bdH1FFxXqgAPUv0Tsr adHlDisKexor9rWjlP3ZgTJ/NMjsbykJPGR37OShcYttKUczqEAkNwjUdF2aB8LbCqJ3 1ECBoQIyInCXqOXU/3YCysTwsPX4wdzRfMcRQXR0ELK8U1TCeZCza0vueCtQXptV29Th quRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OoRzPfuCM7vs2QtUS+yVnYK5sqva1RZlWPK2nX2Hv+0=; b=iwstzIRcG2HVVjxjc/asSbIUWDbzkya+ioTUWCC3Aa57JIJb/dsli7q/IlOEa8d1qQ mfgElhG3xZd7Iws3ps+QD2oLaKSSOZv/2rzMiFitYspcduwWyCiRaEELKdw2Xo0Ws4ce HToparuHrNMvrJBoh36OwCIJd4EOk/PDfuFxu3S+I565dslvo9QImFX/ldgMSpF/6WcR Fu0X3BNkxIHQPorRYEi3UnxUZy8E/c4hPVn3wthqUvolvwxU9/o5YTRVDIOpzzCn1541 lME1Shnck0aypFi0LvBNU1vQfyjkRTw2i6tJH6WvmU0ECdr0QYVnja9XTk4C3rh5TZdc z8+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zzu34Nxx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f21si1470121otf.128.2020.03.17.01.34.42; Tue, 17 Mar 2020 01:34:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zzu34Nxx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726417AbgCQIc5 (ORCPT + 99 others); Tue, 17 Mar 2020 04:32:57 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:39778 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726082AbgCQIc5 (ORCPT ); Tue, 17 Mar 2020 04:32:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584433975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OoRzPfuCM7vs2QtUS+yVnYK5sqva1RZlWPK2nX2Hv+0=; b=Zzu34Nxxzgp9S7Nzs0hJI6dJ0RsQVGYx8oKDZhwHjfTvwLin+SAMISy6492R2qafKAEXUR GzYzTXGv6Xe2/wWEyVEwnU43FX82lGWl7psn6ZCQFGubg+9yXhU20vQrWr1LlufmqM8lhi Vq7JZUBIGle2eAcxebHSonNOYCrJLEo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-5Xc1f0L3PV-XRhNNjcmdMQ-1; Tue, 17 Mar 2020 04:32:51 -0400 X-MC-Unique: 5Xc1f0L3PV-XRhNNjcmdMQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 597271B2C991; Tue, 17 Mar 2020 08:32:49 +0000 (UTC) Received: from dcbz.redhat.com (ovpn-112-179.ams2.redhat.com [10.36.112.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id C92A260BF3; Tue, 17 Mar 2020 08:32:46 +0000 (UTC) From: Adrian Reber To: Christian Brauner , Eric Biederman , Pavel Emelyanov , Oleg Nesterov , Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin Cc: linux-kernel@vger.kernel.org, Mike Rapoport , Radostin Stoyanov , Adrian Reber , Michael Kerrisk , Arnd Bergmann , Cyrill Gorcunov , Thomas Gleixner Subject: [PATCH 3/4] clone3: align structs and comments Date: Tue, 17 Mar 2020 09:30:43 +0100 Message-Id: <20200317083043.226593-4-areber@redhat.com> In-Reply-To: <20200317083043.226593-1-areber@redhat.com> References: <20200317083043.226593-1-areber@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To follow the existing style this commit aligns the comments and structure settings to have the same look as before. Just with more spaces. Signed-off-by: Adrian Reber --- include/uapi/linux/sched.h | 72 +++++++++++++++++++------------------- kernel/fork.c | 18 +++++----- 2 files changed, 45 insertions(+), 45 deletions(-) diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h index c9b36ef647cc..86387052de19 100644 --- a/include/uapi/linux/sched.h +++ b/include/uapi/linux/sched.h @@ -45,42 +45,42 @@ #ifndef __ASSEMBLY__ /** * struct clone_args - arguments for the clone3 syscall - * @flags: Flags for the new process as listed above. - * All flags are valid except for CSIGNAL and - * CLONE_DETACHED. - * @pidfd: If CLONE_PIDFD is set, a pidfd will be - * returned in this argument. - * @child_tid: If CLONE_CHILD_SETTID is set, the TID of the - * child process will be returned in the child's - * memory. - * @parent_tid: If CLONE_PARENT_SETTID is set, the TID of - * the child process will be returned in the - * parent's memory. - * @exit_signal: The exit_signal the parent process will be - * sent when the child exits. - * @stack: Specify the location of the stack for the - * child process. - * Note, @stack is expected to point to the - * lowest address. The stack direction will be - * determined by the kernel and set up - * appropriately based on @stack_size. - * @stack_size: The size of the stack for the child process. - * @tls: If CLONE_SETTLS is set, the tls descriptor - * is set to tls. - * @set_tid: Pointer to an array of type *pid_t. The size - * of the array is defined using @set_tid_size. - * This array is used to select PIDs/TIDs for - * newly created processes. The first element in - * this defines the PID in the most nested PID - * namespace. Each additional element in the array - * defines the PID in the parent PID namespace of - * the original PID namespace. If the array has - * less entries than the number of currently - * nested PID namespaces only the PIDs in the - * corresponding namespaces are set. - * @set_tid_size: This defines the size of the array referenced - * in @set_tid. This cannot be larger than the - * kernel's limit of nested PID namespaces. + * @flags: Flags for the new process as listed above. + * All flags are valid except for CSIGNAL and + * CLONE_DETACHED. + * @pidfd: If CLONE_PIDFD is set, a pidfd will be + * returned in this argument. + * @child_tid: If CLONE_CHILD_SETTID is set, the TID of the + * child process will be returned in the child's + * memory. + * @parent_tid: If CLONE_PARENT_SETTID is set, the TID of + * the child process will be returned in the + * parent's memory. + * @exit_signal: The exit_signal the parent process will be + * sent when the child exits. + * @stack: Specify the location of the stack for the + * child process. + * Note, @stack is expected to point to the + * lowest address. The stack direction will be + * determined by the kernel and set up + * appropriately based on @stack_size. + * @stack_size: The size of the stack for the child process. + * @tls: If CLONE_SETTLS is set, the tls descriptor + * is set to tls. + * @set_tid: Pointer to an array of type *pid_t. The size + * of the array is defined using @set_tid_size. + * This array is used to select PIDs/TIDs for + * newly created processes. The first element in + * this defines the PID in the most nested PID + * namespace. Each additional element in the array + * defines the PID in the parent PID namespace of + * the original PID namespace. If the array has + * less entries than the number of currently + * nested PID namespaces only the PIDs in the + * corresponding namespaces are set. + * @set_tid_size: This defines the size of the array referenced + * in @set_tid. This cannot be larger than the + * kernel's limit of nested PID namespaces. * @timens_offset: Pointer to an array of clock offsets for the * newly created process in a time namespaces. * This requires that a new time namespace has been diff --git a/kernel/fork.c b/kernel/fork.c index f80aca79d263..6e9acac1d347 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2652,15 +2652,15 @@ noinline static int copy_clone_args_from_user(str= uct kernel_clone_args *kargs, return -EINVAL; =20 *kargs =3D (struct kernel_clone_args){ - .flags =3D args.flags, - .pidfd =3D u64_to_user_ptr(args.pidfd), - .child_tid =3D u64_to_user_ptr(args.child_tid), - .parent_tid =3D u64_to_user_ptr(args.parent_tid), - .exit_signal =3D args.exit_signal, - .stack =3D args.stack, - .stack_size =3D args.stack_size, - .tls =3D args.tls, - .set_tid_size =3D args.set_tid_size, + .flags =3D args.flags, + .pidfd =3D u64_to_user_ptr(args.pidfd), + .child_tid =3D u64_to_user_ptr(args.child_tid), + .parent_tid =3D u64_to_user_ptr(args.parent_tid), + .exit_signal =3D args.exit_signal, + .stack =3D args.stack, + .stack_size =3D args.stack_size, + .tls =3D args.tls, + .set_tid_size =3D args.set_tid_size, .timens_offset_size =3D args.timens_offset_size, }; =20 --=20 2.24.1