Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp3529225ybh; Tue, 17 Mar 2020 01:42:31 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuqJ1dGpWIop26qyCfzENnQtHZNRH2v3QcCWgyu2cI291786auS2TKk1tSDwOx2jjehuTk6 X-Received: by 2002:aca:dac5:: with SMTP id r188mr2729198oig.176.1584434551427; Tue, 17 Mar 2020 01:42:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584434551; cv=none; d=google.com; s=arc-20160816; b=OTxGx2tZKVHHV33JNDIIyN3QO/Diq34rhyFfHitaM9eg9EbcWPHzYf0p6UQsV9KXbz g7R9SqkfREcF8rFtkM2IPZMnTei/8vbDWV/3/4nq5Um79G1QekwZ8QFnHA8QIfiuRiF4 68EvTspSJI/zjnPDflN62QLnxDi4f/+I6I74dRkeYBgzafseQBFxgJPm9k+2qtSRwnzG 9Vh07HYiSvgwYjvP8rzb1hvKIS7LSIDSeJEqBcPPBo3VO9aga9qqmJQ0beAIjXGRZPyz iEs/XkI1OI+JGKZ7Ub1/a7PuMw4jV7z8UHyQwXJcXGgxRBMaY1KM5BUL7TWED4wn0Akr R4ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=8KAPg4bTos1rY9vws0C/xCO+F9oh55hyP0CnonU852I=; b=kUujrrSbrQXLjWWBVJvDI5K62CxOLdy3RBRiFcbu1hvJ8vDXZMPexh+ZxcfYWLOaYL NwkXA5fxnuSCZENGTvlPRnSXqhmZVbaCQSESnPYdGU8wQTUPfB4ViG8U1AjKVZdSajCs CViYplo3F0ArJY2tVKPVJ0/0TwLNvbVPFipZs6dKS1PAqAi8YN1z+tEOWSjB4WxGDtO+ PvikrB/jXiwkUr8HIjDDbgdj9SCLOGlQJQc4q68cctdP67+ZRisHUAaimwVdqCV0px1x n3wtQVpcxDkDs3R/iuQVvoojXMxNV0DM9iZZPtrAsQw7dLSCfhcqfdAhFPFskj1PAiV2 Zv6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i2si281485oif.204.2020.03.17.01.42.18; Tue, 17 Mar 2020 01:42:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725957AbgCQImB (ORCPT + 99 others); Tue, 17 Mar 2020 04:42:01 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:39126 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbgCQImB (ORCPT ); Tue, 17 Mar 2020 04:42:01 -0400 Received: by mail-ot1-f65.google.com with SMTP id r2so5370266otn.6; Tue, 17 Mar 2020 01:41:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8KAPg4bTos1rY9vws0C/xCO+F9oh55hyP0CnonU852I=; b=iubqMyUjFGwNTCeuykhwnWPzi4ZrZ5EAUPhIabkVYgSTUKLyhu0/Oq8Ej1wsSQ+Lhr FVEjQixNIRRE46dW4+rFtOr1cutw+RabudP3D52+hPUkpmrTxBDJisfA/yJwx1f6rmLO X4vETRYEpsYWPE0GWBbd4kUyPXL8wnq/9vnUZyKo7qF1awioM9aH7npPywhmNMcDvx73 2ZU4QqcbSUSzl8d/iQWMAUjo2Mu4K+5TCNS1PXNn06R7/mKjAL5HRELuqimlg19z8yk4 d11x4D3uhpfK6WSjEwagBzsIYNMpZQWEbdPFsdFspkT4keJXCGDRM4eYBH8AyrciIcaq NBwQ== X-Gm-Message-State: ANhLgQ26eX7G394qQtfH2C+Y4ZRrRj+jDJHMnLERKIzaUsN8u5SW7faW Dg48UiVckW6MyEJqHVrHGM7QUC/OqdhE0lTVY7g= X-Received: by 2002:a9d:8d0:: with SMTP id 74mr2800645otf.39.1584434518599; Tue, 17 Mar 2020 01:41:58 -0700 (PDT) MIME-Version: 1.0 References: <20200218151812.7816-1-geert+renesas@glider.be> <20200218151812.7816-2-geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 17 Mar 2020 09:41:47 +0100 Message-ID: Subject: Re: [PATCH v5 1/5] gpiolib: Add support for gpiochipN-based table lookup To: Linus Walleij Cc: Bartosz Golaszewski , Jonathan Corbet , Harish Jenny K N , Eugeniu Rosca , Alexander Graf , Peter Maydell , Paolo Bonzini , Phil Reid , Marc Zyngier , Christoffer Dall , Magnus Damm , Rob Herring , Mark Rutland , "open list:GPIO SUBSYSTEM" , Linux Doc Mailing List , Linux-Renesas , "linux-kernel@vger.kernel.org" , QEMU Developers Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On Thu, Mar 12, 2020 at 3:23 PM Linus Walleij wrote: > On Tue, Feb 18, 2020 at 4:18 PM Geert Uytterhoeven > wrote: > > > Currently GPIO controllers can only be referred to by label in GPIO > > lookup tables. > > > > Add support for looking them up by "gpiochipN" name, with "N" the > > corresponding GPIO device's ID number. > > > > Signed-off-by: Geert Uytterhoeven > > Reviewed-by: Ulrich Hecht > > Reviewed-by: Eugeniu Rosca > > Tested-by: Eugeniu Rosca > > Just like with patch 2/5 I have the same problem here that > the commit message doesn't state the technical reason why > we need to change this and support the device name in these > tables and not just labels. As these "gpiochipN" names are not stable, I will drop this patch, and the related support. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds