Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init
To:     Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>
References: <20200317040742.12143-1-rayagonda.kokatanur@broadcom.com>
From:   Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <e94bbb2c-6f36-61bb-d26a-2ce3e1a139e0@cogentembedded.com>
Date:   Tue, 17 Mar 2020 12:09:32 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200317040742.12143-1-rayagonda.kokatanur@broadcom.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello!

On 17.03.2020 7:07, Rayagonda Kokatanur wrote:

> Remove unused variable initialization.

    I think it's not an initialization, it's an assignment. :-)

> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> ---
>   drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index ed10da5313e8..6fd62657e35f 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
>   	prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
>   
>   	while (rbytes)  {
> -		nbytes = rbytes;
> -
>   		nbytes = min_t(u32, rbytes, param[0].u.memref.size);
>   
>   		/* Fill additional invoke cmd params */

MBR, Sergei