Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200317040742.12143-1-rayagonda.kokatanur@broadcom.com> <e94bbb2c-6f36-61bb-d26a-2ce3e1a139e0@cogentembedded.com>
In-Reply-To: <e94bbb2c-6f36-61bb-d26a-2ce3e1a139e0@cogentembedded.com>
From:   Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Date:   Tue, 17 Mar 2020 15:23:20 +0530
Message-ID: <CAHO=5PEiPK=uF_rEJ+ujaP=oq2fPR1VHvczjZ1JQAqDdjTsMHQ@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init
To:     Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        linux-mips@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 17, 2020 at 2:39 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>
> Hello!
>
> On 17.03.2020 7:07, Rayagonda Kokatanur wrote:
>
> > Remove unused variable initialization.
>
>     I think it's not an initialization, it's an assignment. :-)
Thanks  will fix it and send v2.
>
> > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> > ---
> >   drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > index ed10da5313e8..6fd62657e35f 100644
> > --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> > +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
> >       prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
> >
> >       while (rbytes)  {
> > -             nbytes = rbytes;
> > -
> >               nbytes = min_t(u32, rbytes, param[0].u.memref.size);
> >
> >               /* Fill additional invoke cmd params */
>
> MBR, Sergei