Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp3601655ybh; Tue, 17 Mar 2020 03:12:01 -0700 (PDT) X-Google-Smtp-Source: ADFU+vucPiFspddwfK5imzhJT6hMqmu8r5/e48sPqgkRDxKPdGEgFWCAE64gTxQu6MpY7yuOXbPF X-Received: by 2002:a9d:175:: with SMTP id 108mr3094743otu.68.1584439921144; Tue, 17 Mar 2020 03:12:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584439921; cv=none; d=google.com; s=arc-20160816; b=yTJTJS2FmQipgtgh6JrUoAb+sw7WIUy9jEvplW5hUmJyLA8QXnBEg6nTPAGntj0lu8 VTloeGvkRgMjc7X93vt6PDJimqkRdKzDHReLDX6c1H3LgCwpWTTBuFHsBwo4acgWacLB pEkTFQsU3Kk9EhluD7pIk8UDUkdF+zrM/G8je67QejyFT/DhL2eKOhGfuZ2r6KJE2Nn6 k5uAYbEhFyWJmIeyfd2wUOfEtO5GmYvuDfbgOnhLUkMhTwRDGWLaT4VrOK2rQowSgoNy ZOKpYCz5PHj5vh6SchPBzTpCjP6MJqkw+LQANDXgB3/eesn1mFT89OQg2oDwEjYaCcnB H5Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=54bgmSfx02XfILTM/lH2V3KeKOUWxzYd5zSBErlsSvE=; b=gY/GS+Ee0srQR+lC5QsfadID4VgW0dieTYSk8KfZ2eybjl4aD+T9ho2wn4UoYTR2B9 K/9xO3n31SpSOwek8krEX9ypBjEOp2vg7hk1eaMkzRugPx0gvqjLESpo2h5JbOi0tW2R 7stwMsgme/8l7tn/QTqSEQtk46wkRXeJeltm4/FZKKXlqGYY1auVx4/yd7J/oVrGS9Sj kKb27E+xnXF+Sajl+dcG7FiuyyAk8akb4TohySS8wwP0w2NntMVEqpYOpaMFgLW7c6HK zu2GtDAAc5Um5HJbbMyTMla9RBtFZ7Nap0Y16lndMtby/TASMcUKkBCuXsN8LxXLFZPK wKbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d185si1491892oif.234.2020.03.17.03.11.48; Tue, 17 Mar 2020 03:12:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726187AbgCQKK7 convert rfc822-to-8bit (ORCPT + 99 others); Tue, 17 Mar 2020 06:10:59 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]:45180 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbgCQKK7 (ORCPT ); Tue, 17 Mar 2020 06:10:59 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-253-m8c9lr4xM2eSzCLFFXrRRA-1; Tue, 17 Mar 2020 10:10:53 +0000 X-MC-Unique: m8c9lr4xM2eSzCLFFXrRRA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 17 Mar 2020 10:10:53 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Tue, 17 Mar 2020 10:10:53 +0000 From: David Laight To: 'David Miller' , "wei.zheng@vivo.com" CC: "catalin.marinas@arm.com" , "will@kernel.org" , "jdmason@kudzu.us" , "yeyunfeng@huawei.com" , "guohanjun@huawei.com" , "tglx@linutronix.de" , "info@metux.net" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "kernel@vivo.com" , "wenhu.wang@vivo.com" Subject: RE: [PATCH] net: vxge: fix wrong __VA_ARGS__ usage Thread-Topic: [PATCH] net: vxge: fix wrong __VA_ARGS__ usage Thread-Index: AQHV+97YYm2kZGPR3k6KR+yWy8keoqhMkFUA Date: Tue, 17 Mar 2020 10:10:53 +0000 Message-ID: References: <20200316142354.95201-1-wei.zheng@vivo.com> <20200316.150416.703162062113777580.davem@davemloft.net> In-Reply-To: <20200316.150416.703162062113777580.davem@davemloft.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > printk in macro vxge_debug_ll uses __VA_ARGS__ without "##" prefix, > > it causes a build error when there is no variable > > arguments(e.g. only fmt is specified.). > > > > Signed-off-by: Zheng Wei > > Does this even happen right now? Anyways, applied. I thought most of the compilers removed the lurking ',' using some heristic. A safer alternative is to include the 'fmt' in the ... then there is always one argument. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)