Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: AplRtMpY1kl8eiwXbK0UGW6Z5Klcs4VAZUqkAn5xJBqnHEVYJAo78Dk2ZfSdhxkXR7BkXH0gsV
 sGSecrkZi1JA==
IronPort-SDR: avYLoU5oKBnNWle2OyBEP5KMiCsT95QvG44wtlSDfOOZGq/StK1wl4Z0n2rgcUh84/QMi5Ky/K
 Rz5B6/MDFc3w==
Date:   Tue, 17 Mar 2020 12:42:23 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Martin Kepplinger <martin.kepplinger@puri.sm>
Cc:     dmitry.torokhov@gmail.com, m.felsch@pengutronix.de,
        mylene.josserand@bootlin.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: edt-ft5x06 - add fw_version debugfs file to read
Message-ID: <20200317104223.GA1922688@smile.fi.intel.com>
References: <20200316142756.25344-1-martin.kepplinger@puri.sm>
 <20200316144020.GN1922688@smile.fi.intel.com>
 <40d823d7-5873-2a3c-9f49-87fdb7428061@puri.sm>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <40d823d7-5873-2a3c-9f49-87fdb7428061@puri.sm>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 17, 2020 at 11:25:39AM +0100, Martin Kepplinger wrote:
> On 16.03.20 15:40, Andy Shevchenko wrote:
> > On Mon, Mar 16, 2020 at 03:27:56PM +0100, Martin Kepplinger wrote:
> >> Add simple fw_version file in debugfs to read the value from 0xa6
> >> which is the firmware version.
> > 
> > 
> > If you switch to regmap I?C API you will get this for free for all defined
> > registers.
> > 
> > So, I highly recommend to consider above.
> > 
> 
> I don't know all the devices and modes well enough if the current raw
> read/write buffers always translate to (only) buf[0] being the register
> address.
> 
> If you tell me I can assume just that, I'm happy to do a larger change
> that completely does aways with the current raw buffers.

I have only one device at hand, so, I can't tell for all neither.
Maybe Dmitry has an opinion on this?

> Otherwise:
> 
> Does is make sense to *add* just a few regmap calls but keep the current
> i2c_transfer in place for the calls I'm not sure about? I could do that
> in any case.

I think it's way to the opposite direction, i.e. increasing burden
(for maintainability) and technical debt.

-- 
With Best Regards,
Andy Shevchenko