Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: Y9SGIQ/bR4v2R4R5Sdk5N2uvzxJZQN0lgJyP1r3JPDm5T0n49s+tVsfwcvSOK4uvwD/BS6enOQ
 e1BxFaHR4dZA==
From:   SeongJae Park <sjpark@amazon.com>
To:     SeongJae Park <sj38.park@gmail.com>
CC:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
        SeongJae Park <sjpark@amazon.com>, <akpm@linux-foundation.org>,
        SeongJae Park <sjpark@amazon.de>, <aarcange@redhat.com>,
        <yang.shi@linux.alibaba.com>, <acme@kernel.org>,
        <alexander.shishkin@linux.intel.com>, <amit@kernel.org>,
        <brendan.d.gregg@gmail.com>, <brendanhiggins@google.com>,
        <cai@lca.pw>, <colin.king@canonical.com>, <corbet@lwn.net>,
        <dwmw@amazon.com>, <jolsa@redhat.com>, <kirill@shutemov.name>,
        <mark.rutland@arm.com>, <mgorman@suse.de>, <minchan@kernel.org>,
        <mingo@redhat.com>, <namhyung@kernel.org>, <peterz@infradead.org>,
        <rdunlap@infradead.org>, <rientjes@google.com>,
        <rostedt@goodmis.org>, <shuah@kernel.org>, <vbabka@suse.cz>,
        <vdavydov.dev@gmail.com>, <linux-mm@kvack.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: Re: Re: [PATCH v6 02/14] mm/damon: Implement region based sampling
Date:   Tue, 17 Mar 2020 12:32:05 +0100
Message-ID: <20200317113205.3617-1-sjpark@amazon.com>
In-Reply-To: <20200313201649.26646-1-sj38.park@gmail.com> (raw)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 13 Mar 2020 21:16:49 +0100 SeongJae Park <sj38.park@gmail.com> wrote:

> On Fri, 13 Mar 2020 17:29:54 +0000 Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> 
> > On Mon, 24 Feb 2020 13:30:35 +0100
> > SeongJae Park <sjpark@amazon.com> wrote:
> > 
> > > From: SeongJae Park <sjpark@amazon.de>
> > > 
> > > This commit implements DAMON's basic access check and region based
> > > sampling mechanisms.  This change would seems make no sense, mainly
> > > because it is only a part of the DAMON's logics.  Following two commits
> > > will make more sense.
> > > 
> [...]
> > 
> > Came across a minor issue inline.  kthread_run calls kthread_create.
> > That gives a potential sleep while atomic issue given the spin lock.
> > 
> > Can probably be fixed by preallocating the thread then starting it later.
> > 
> > Jonathan
> [...]
> > > +/*
> > > + * Start or stop the kdamond
> > > + *
> > > + * Returns 0 if success, negative error code otherwise.
> > > + */
> > > +static int damon_turn_kdamond(struct damon_ctx *ctx, bool on)
> > > +{
> > > +	spin_lock(&ctx->kdamond_lock);
> > > +	ctx->kdamond_stop = !on;
> > > +	if (!ctx->kdamond && on) {
> > > +		ctx->kdamond = kthread_run(kdamond_fn, ctx, "kdamond");
> > 
> > Can't do this under a spin lock.
> 
> Good catch!  And, agree to your suggestion.  I will fix this in that way!

I changed my mind.  I would like to simply use mutex instead of spinlock, as
khugepaged also does.  If you have different opinion, please let me know.


Thanks,
SeongJae Park

> 
> 
> Thanks,
> SeongJae Park