Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1584333244-10480-1-git-send-email-kernelfans@gmail.com>
 <1584333244-10480-3-git-send-email-kernelfans@gmail.com> <20200316085536.GB1831@infradead.org>
In-Reply-To: <20200316085536.GB1831@infradead.org>
From:   Pingfan Liu <kernelfans@gmail.com>
Date:   Tue, 17 Mar 2020 19:45:42 +0800
Message-ID: <CAFgQCTuyZjLRBW1g7cMWhbqm48UMX+wCK4e6m2nGqnmM8ScLRQ@mail.gmail.com>
Subject: Re: [PATCHv6 2/3] mm/gup: fix omission of check on FOLL_LONGTERM in
 gup fast path
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Linux-MM <linux-mm@kvack.org>, Ira Weiny <ira.weiny@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        John Hubbard <jhubbard@nvidia.com>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
        Shuah Khan <shuah@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 16, 2020 at 4:55 PM Christoph Hellwig <hch@infradead.org> wrote:
>
[...]
>
> Wrong indentation.  We either align two tabs for continuation
> statements, or after the opening brace of the previous line.  With a
> likely or unlikely thrown in the former IMHO looks much better.  E.g.
>
>                 if (unlikely(flags & FOLL_LONGTERM) &&
>                                 is_migrate_cma_page(page))
>                         return NULL;
>
OK, thanks. I will send out V7 to fix it.

Regards,
Pingfan