Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp3766003ybh; Tue, 17 Mar 2020 06:16:19 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtvCnDP4KRxn8l/xC1XwClxFh5rRvzToWx3AOAxJm35H5ezBDDCSSQtjFYf09Arirp0bMir X-Received: by 2002:a9d:3603:: with SMTP id w3mr3698183otb.94.1584450979151; Tue, 17 Mar 2020 06:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584450979; cv=none; d=google.com; s=arc-20160816; b=tp5eB/YYQ6h4ngJsRL/CtloTSLf1BMmFxV9wfl2JePvC+SmFdBKI9SOn3SRCpP3hhJ EQ6Xq2XeO3tlYToXGQGmEsoP9Ti6HHziOfKsf9ufMZqByiAjsAAg5lZZmU5Lw3+KrOzO h/ochtSinRgE6pVQquCD4fnGos7AOK6Y68HdTeh8nslCBUtbz2Zov6+BvQkosfMM4Kq3 NeesU4u1Ey4D8lVeTI1DtDwe+lZo68OpgMq7yN08MI2YT3J0z5ozmUCLaeBZcQeEB45m 783rC5Ew5JKzy8XuFN+gtkRcVdBhXhIrBS+h52ilwDypRtNdqG8X0k8x+znb/REkyHnw knGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=xWLW2Ua7sXmQswzyX6PNhZ8veKzHgdXOQQkjw61WEoI=; b=FkKYuOh5l7mQWJDccrjo4cIMSjQpqFK+fNLV4phZ+NWqsipFgDMxdHDTOoxnDaop6A P7H0mRow2Gp5aU5vya87JydWZ9fmcRCc9Eu38o6yo0SZD3uwnJmw6lmutJMXwH48A6ef kYgQk49kZgFlXEMMluueIFlQBbZIe4HBvMMynzRPd1YktGezJrvB7nFigdHiBZaUqXvm TNxGCvSkjK8dIdjW37AHLmoNAi55ixvBE1Thv6IuB3ZuKURR8YnbPeOQHZq0h9vc+30C 89YTXKqWt4D/k4Oc6HdALEeEOnMhhXzUfAWlyPsO/+GSAfyUmev79ER+FyGc08l0CueL yYUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t205si1715922oib.49.2020.03.17.06.16.02; Tue, 17 Mar 2020 06:16:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbgCQNOy (ORCPT + 99 others); Tue, 17 Mar 2020 09:14:54 -0400 Received: from ozlabs.org ([203.11.71.1]:36657 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726814AbgCQNOx (ORCPT ); Tue, 17 Mar 2020 09:14:53 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 48hYYQ3LhHz9sSX; Wed, 18 Mar 2020 00:14:50 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: cc6f0e39000900e5dd1448103a9571f0eccd7d4e In-Reply-To: To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , ndesaulniers@google.com From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/32: Fix missing NULL pmd check in virt_to_kpte() Message-Id: <48hYYQ3LhHz9sSX@ozlabs.org> Date: Wed, 18 Mar 2020 00:14:50 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-03-07 at 10:09:15 UTC, Christophe Leroy wrote: > Commit 2efc7c085f05 ("powerpc/32: drop get_pteptr()"), > replaced get_pteptr() by virt_to_kpte(). But virt_to_kpte() lacks a > NULL pmd check and returns an invalid non NULL pointer when there > is no page table. > > Reported-by: Nick Desaulniers > Fixes: 2efc7c085f05 ("powerpc/32: drop get_pteptr()") > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/cc6f0e39000900e5dd1448103a9571f0eccd7d4e cheers