Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp3857934ybh; Tue, 17 Mar 2020 07:52:43 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvav6G5TKtwYjJChKW2OD4Y891Fl+3PnXhkE3Yxf+jNHTonmVjbZ0yIFVSlv7nhPRZ1aHOI X-Received: by 2002:a05:6830:118d:: with SMTP id u13mr3796833otq.41.1584456763306; Tue, 17 Mar 2020 07:52:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584456763; cv=none; d=google.com; s=arc-20160816; b=kLbaEzhV1Kf+oS0N8iMBVhBt7AJL9EvFPco6PMi8w5bQbg+Zjec8AGc6dpvkkXQF0G 9qD+vBg26wEcZU/Kiubzjr8q8otiy33/nbkFdT07/EWLmwiYJjiguKdjIw4GUFqIBiZp IjV8/FTm16zS3I+6nFsekvea8wHkA41vydqtYX9G8+bP89G6GQiNqQiV5bjzPz5TnPAo A+IvoMnqpOj1uFOIAAI5kjKaw+Fx6M8kJLQZUHVv7qxsEhBuCvc87XdTQ/d4zE1mTvl3 r7zTqOx6dZzbOuqN0zG0GoKklOBlQXeaYST0vJnmbnAsSNxNKotLpwjxYPSuMsvuVqDG 6xMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=FDks3QHxcsjqmidiKzVZYru591ydgUN9SL4yR0RuYqE=; b=C5oK1ON5Ynj2xIvq3Uu7Tb8gD55HjyiBhVN/FV6Ud1rqNkSyzavKibMncaoTtY/mA+ UcVdda/kkt0Dl2v3xtByVHtTCn7OfNwi95Vx7JSy6ERmxNvuJ7jYsDuZMkPmC2TvHwZg SwQcDrUyQnr16JHd/c/MZmcHz3lhH/lhJYHqx3RymL2BH+lxaemzabC0RDOzLr5CqY9v oO+Tk4rMdThXC3m/GzbuOL2vbYEgLS9b7cH2bnc1YzEixUBHFAoDG1xfU7CJEEecNKGg nAoSohA748lXWE7bRfkixiIoFbI3XHhz/xhFBAM39TccNkQXQmKS3I1xZoK2BRZC8Jhm bTuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6si1735804otm.298.2020.03.17.07.52.31; Tue, 17 Mar 2020 07:52:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726647AbgCQOvK (ORCPT + 99 others); Tue, 17 Mar 2020 10:51:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:39978 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbgCQOvK (ORCPT ); Tue, 17 Mar 2020 10:51:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EDA10AFFD; Tue, 17 Mar 2020 14:51:07 +0000 (UTC) Subject: Re: [PATCH] mm/vmscan: add vm_swappiness configuration knobs To: Michal Hocko Cc: Ivan Teterevkov , "corbet@lwn.net" , "akpm@linux-foundation.org" , "mchehab+samsung@kernel.org" , "tglx@linutronix.de" , "jpoimboe@redhat.com" , "pawan.kumar.gupta@linux.intel.com" , "jgross@suse.com" , "oneukum@suse.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" References: <20200312092531.GU23944@dhcp22.suse.cz> <20200312132642.GW23944@dhcp22.suse.cz> <4ea2e014-17ea-6d1e-a6cd-775fb6550cd2@suse.cz> <20200317082913.GE26018@dhcp22.suse.cz> From: Vlastimil Babka Message-ID: <4e08008f-bf20-6a9c-0ffb-f6438c326612@suse.cz> Date: Tue, 17 Mar 2020 15:51:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200317082913.GE26018@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/17/20 9:29 AM, Michal Hocko wrote: > On Mon 16-03-20 15:53:21, Vlastimil Babka wrote: >> On 3/12/20 2:26 PM, Michal Hocko wrote: > > This sounds like a much better idea than a case by case handling. I > wouldn't be surprised if some kernel parameters would duplicate sysctl > values. I cannot judge the implementation unfortunately but from a quick > glance it makes sense to me. Especially where you hooked it into because > not all handlers are simple setters for a global value. Some of them > have a much more complicated logic which requires a lot of > infrastructure to be set up already. So putting do_sysctl_args right > before the init is executed should be good enough. > > Care to post an RFC to a larger audience? Let's see where we get from > there. FYI done: (I didn't CC everybody from this thread) https://lore.kernel.org/linux-api/20200317132105.24555-1-vbabka@suse.cz/