Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp3886793ybh; Tue, 17 Mar 2020 08:20:50 -0700 (PDT) X-Google-Smtp-Source: ADFU+vupPWhFOCm2sd4JXbY0p3smi7OVWhF1IpYYg8T2ZQz+m6yclpFBif5lhNV7xVwsEfpCySV4 X-Received: by 2002:aca:aa55:: with SMTP id t82mr3900195oie.147.1584458450641; Tue, 17 Mar 2020 08:20:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584458450; cv=none; d=google.com; s=arc-20160816; b=Z3hABCTb82dH/qEoYoGoGAshj15GCZ+61uhga6R5aPp9fxnvY7XjW2VgOgsTXk2UA9 ayOvHqQHOxaLY2azvT5e6X7rmEwo+/aszqvB7l/TaxMSFoQ1myEMlJuGkGutW0Qclcip Np3OGUR7VFu4rpEF1VcgTosyxyjjaoummZwsDA2WOVreTKDb0AJLPWd95DvOyN26LU/b ME/Aea1YbsMNErQCbIpFF79WLmlP6OP2rFCrXU5h7Bz7sXFeKh3SOqrAI0ygeYwxbPbY 2pdqTV9e6aQ6PmzWwiyFdboA9YinqzbSSWQHNJ8wVJ7qUDaGVpwf8ODZn9aWcc8gojwv DM4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:in-reply-to:mime-version:references :message-id:subject:cc:to:from:date; bh=P7q6YjU+FZwBYI9rYrCld6LJ2oiHoptPgyQQ8xbo6R4=; b=OuuypyzY3jura1bl95UPQ4Jzyq9wWWCqpKKWpHDT+DeSsVu1EEg4bMW7M5cEYFmmQU GZMrDwMCW7X7C7uyUciU/EMcDkeyQ2VvH/xbbmzkaQ/asj7XqRpXvrhp3AaWkwxJXpWj InOVJH7V4e3TgTG6/dOcvRpJyj1sJ2hVxb4G8DmlFdQsBlu79MEJRQrlgL+8Ho4MC1b0 4ijR5WbIAWz7ZP3JZ0Dy4qunmavSMWex32UF5GxARokQX16Np/qGzSlNc6xMxY2lJ/gz S8px0jl82IqiFZ/41TpWZMQXM+EjnhB1WwVATa2+mpnFVX7YWNFbtwdQBColxxQVM6Ms KRjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10si379378oif.81.2020.03.17.08.20.37; Tue, 17 Mar 2020 08:20:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727144AbgCQPSg convert rfc822-to-8bit (ORCPT + 99 others); Tue, 17 Mar 2020 11:18:36 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:51101 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727127AbgCQPSg (ORCPT ); Tue, 17 Mar 2020 11:18:36 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-0m0ADeeiPxyOkHpGz1BdgA-1; Tue, 17 Mar 2020 11:18:31 -0400 X-MC-Unique: 0m0ADeeiPxyOkHpGz1BdgA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D568107ACC9; Tue, 17 Mar 2020 15:18:30 +0000 (UTC) Received: from aion.usersys.redhat.com (ovpn-115-53.rdu2.redhat.com [10.10.115.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C47EC19C58; Tue, 17 Mar 2020 15:18:29 +0000 (UTC) Received: by aion.usersys.redhat.com (Postfix, from userid 1000) id 11F001A010E; Tue, 17 Mar 2020 11:18:29 -0400 (EDT) Date: Tue, 17 Mar 2020 11:18:29 -0400 From: Scott Mayhew To: Trond Myklebust Cc: "sfr@canb.auug.org.au" , "paul@paul-moore.com" , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: linux-next: manual merge of the selinux tree with the nfs tree Message-ID: <20200317151829.GA4442@aion.usersys.redhat.com> References: <20200317133117.4569cc6a@canb.auug.org.au> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aion.usersys.redhat.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Mar 2020, Trond Myklebust wrote: > On Tue, 2020-03-17 at 13:31 +1100, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the selinux tree got a conflict in: > > > > fs/nfs/getroot.c > > > > between commit: > > > > e8213ffc2aec ("NFS: Ensure security label is set for root inode") > > > > from the nfs tree and commit: > > > > 28d4d0e16f09 ("When using NFSv4.2, the security label for the root > > inode should be set via a call to nfs_setsecurity() during the mount > > process, otherwise the inode will appear as unlabeled for up to > > acdirmin seconds. Currently the label for the root inode is > > allocated, retrieved, and freed entirely witin > > nfs4_proc_get_root().") > > > > from the selinux tree. > > > > These are basically the same patch with slight formatting > > differences. > > > > I fixed it up (I used the latter) and can carry the fix as necessary. > > This is now fixed as far as linux-next is concerned, but any non > > trivial > > conflicts should be mentioned to your upstream maintainer when your > > tree > > is submitted for merging. You may also want to consider cooperating > > with the maintainer of the conflicting tree to minimise any > > particularly > > complex conflicts. > > > OK... Why is this being pushed through the selinux tree? Was that your > intention Scott? Not really... I addressed the patch to you and Anna, after all. On the other hand, I didn't object when Paul picked up the patch in his tree. I'm guessing I should have spoken up. Sorry about that. -Scott > Given that it didn't touch anything outside NFS and > had been acked by the Selinux folks, but had not been acked by the NFS > maintainers, I was assuming it was waiting to be applied here. > > -- > Trond Myklebust > Linux NFS client maintainer, Hammerspace > trond.myklebust@hammerspace.com > >