Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 17 Mar 2020 19:37:47 -0400
User-Agent: K-9 Mail for Android
In-Reply-To: <20200317224820.GP3199@paulmck-ThinkPad-P72>
References: <20200316163228.62068-1-joel@joelfernandes.org> <20200317210822.GM3199@paulmck-ThinkPad-P72> <20200317214502.GA29184@paulmck-ThinkPad-P72> <CAEXW_YQxKfcGf3UgEn_8hdWHdMx09RvD90z6zo=kk-iRinYjng@mail.gmail.com> <20200317224820.GP3199@paulmck-ThinkPad-P72>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v2 rcu-dev 1/3] rcuperf: Add ability to increase object allocation size
To:     paulmck@kernel.org, "Paul E. McKenney" <paulmck@kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Josh Triplett <josh@joshtriplett.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        rcu <rcu@vger.kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
        "Uladzislau Rezki (Sony)" <urezki@gmail.com>
From:   joel@joelfernandes.org
Message-ID: <A6C6D60E-9E01-40FC-8396-9F2FF2803E2E@joelfernandes.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On March 17, 2020 6:48:20 PM EDT, "Paul E=2E McKenney" <paulmck@kernel=2Eo=
rg> wrote:
>On Tue, Mar 17, 2020 at 06:30:51PM -0400, Joel Fernandes wrote:
>> On Tue, Mar 17, 2020 at 5:45 PM Paul E=2E McKenney <paulmck@kernel=2Eor=
g>
>wrote:
>> >
>> > On Tue, Mar 17, 2020 at 02:08:22PM -0700, Paul E=2E McKenney wrote:
>> > > On Mon, Mar 16, 2020 at 12:32:26PM -0400, Joel Fernandes (Google)
>wrote:
>> > > > This allows us to increase memory pressure dynamically using a
>new
>> > > > rcuperf boot command line parameter called 'rcumult'=2E
>> > > >
>> > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes=2Eorg>
>> > >
>> > > Applied for testing and review, thank you!
>> >
>> > But testing did not go far:
>> >
>> > kernel/rcu/tree=2Ec: In function =E2=80=98kfree_rcu_shrink_count=E2=
=80=99:
>> > kernel/rcu/tree=2Ec:3120:16: warning: unused variable =E2=80=98flags=
=E2=80=99
>[-Wunused-variable]
>> >   unsigned long flags, count =3D 0;
>>=20
>> I fixed the warning already but did not resend since it was just the
>> one unused variable warning=2E The patches are otherwise good to apply=
=2E
>> Sorry, and I can resend it soon if you are not reapplying right now=2E
>
>So remove "flags, " and all is well?

Yes, that's right=2E I dropped the lock but forgot to remove it=2E

>If so, I can just as easily fix that as take a new series=2E  But next
>time, please give a fella a warning=2E  ;-)

Will do, my bad=2E Thank you ;-)

- Joel

>
>							Thanx, Paul

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E