Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp169584ybh; Tue, 17 Mar 2020 20:34:02 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvrAt8MKp0IYWRvU3FvEnEMjby5Gk5HBm28z5cX7YXghEsZGH3mts5P9EA/2P1Ov1T5Jn0f X-Received: by 2002:aca:ed4b:: with SMTP id l72mr1576594oih.95.1584502441896; Tue, 17 Mar 2020 20:34:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584502441; cv=none; d=google.com; s=arc-20160816; b=sRaJITHSSPjlz60ko6G4rXhU62EWRVnlLw9MFDrHKf3rrymSndvJJdm9xqCESmXENl WDAavwXN/l5TLC++RgWshP24RzqvzWrGs8m0Z8QJ17gKOyroiVUf6mKPyvV8WpesQHGd XjFAXyi0FX0Yry0y0XVXt1S/gnphKNxgaKjCduWsqfpcdXNuNge8Tdl64SjSN93zbTfc NJ9ZSO3ZSYX/Uruuvy9Wx3WhMMp2QpHHh8lInZUci0lWc+M4mCJuezfLQ2qiSePB16gP P/WgrE6Pti6KqdnLD0ev6xsr6aD+dadspOSjCzm8kKAaVUdI2rAm4w9ySe05oVwvmEx6 d/7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Rk1TNn9ccL64hLpFaQmDzETAL+uZeDH4VFQOlNX0f9E=; b=NujQfi9C8tNtM28csrHrwzRNeUKLk9xeL4fDjA/EGARRzzgZ7p9pFQpoFZufGzY7Zd C1yWcmA7nej6oX5Gc1nrkwEoy6BtTZE2sjN1ve1Ob/zckQu58sy4LvTlTPNk3JhnVVUu xkA3oe36DuImEkjep3h7HrPPRPfgAiCQQClSyi7emsJhK5wlv1g1K8pREQw50gRdSiko N+xEInr/kSbCCOxJWRIC399TJayeTQ2SH6utw7KFeUA2NsJUe1DrR1WNF10YGtj2NShY iw4TbaeWPDI/DBD+ZPUyEd9M2N+O2kNSvXIDJEqgzMQOJtyz3MEAaWGK9CuSkGIpSK7A qqtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=JOnwiiMY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l131si2627372oih.10.2020.03.17.20.33.50; Tue, 17 Mar 2020 20:34:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=JOnwiiMY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbgCRDcE (ORCPT + 99 others); Tue, 17 Mar 2020 23:32:04 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:36347 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbgCRDcD (ORCPT ); Tue, 17 Mar 2020 23:32:03 -0400 Received: by mail-lj1-f196.google.com with SMTP id g12so25395372ljj.3 for ; Tue, 17 Mar 2020 20:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Rk1TNn9ccL64hLpFaQmDzETAL+uZeDH4VFQOlNX0f9E=; b=JOnwiiMYFQXtb2xnbGwhKz2wC2VxNj9jz34jNn6+JFXWTYBEuuhSpw7vmLqyqfR8I7 zExlhZ11nargyUNu4yQs63Nd52Y5BorRDxLkhY1n4VFcMoJ+3q2JJB5i5OhkUn9dGBDl ksKn4N4/9yCDI6+ZSGaOo2/gOB6ODxXI8uDT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rk1TNn9ccL64hLpFaQmDzETAL+uZeDH4VFQOlNX0f9E=; b=KcpIIFeXwk4PyovBVpWopVpP+vwiB4rVkGKQCGooexpopCVFKRxNHziyiS3dpNRFZn 02ATNeF3H+SEO8MnI8xH1xKTleBf0A7+q53snlLOy/noM7JoOyeBUu+16Pi7S6xIEh9M Z8USkpCF6ojCSsB3V6k4MEMwFCeMEVyNZ+GhZ1OqUSxhzqaX1DeS5XupbEKsHRwHQieY RIMY3jnyCRrsU2z6808oEzpvw3LrOBR/+SUm5LuxHJR5HRT9xlRU9uUvyvvssvWP+wnH uoC16N1T0T2dB1hib45kFUsiV92w4C2rp74A/swJ2OBVj7fzrEn3TF38iKgMK2YOgiFf EUrA== X-Gm-Message-State: ANhLgQ39Mnf5vvwfdX0k/eJq/F1SQ+YgB2Lp0WiS2AvWPoRcRnmhk/xI VM0+hmfRTnKu1lCmWJ8w0pvKWkgVjkn72Z20kcl/dw== X-Received: by 2002:a2e:9214:: with SMTP id k20mr1105319ljg.157.1584502321247; Tue, 17 Mar 2020 20:32:01 -0700 (PDT) MIME-Version: 1.0 References: <20200317042216.20623-1-rayagonda.kokatanur@broadcom.com> <20200317192916.GA708@MININT-65B7IF6> In-Reply-To: <20200317192916.GA708@MININT-65B7IF6> From: Rayagonda Kokatanur Date: Wed, 18 Mar 2020 09:01:49 +0530 Message-ID: Subject: Re: [PATCH v1 1/1] maillbox: bcm-flexrm-mailbox: handle cmpl_pool dma allocation failure To: Tyler Hicks Cc: Jassi Brar , Linux Kernel Mailing List , BCM Kernel Feedback Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2020 at 1:01 AM Tyler Hicks wrote: > > On 2020-03-17 09:52:16, Rayagonda Kokatanur wrote: > > Handle 'cmpl_pool' dma memory allocation failure. > > > > Signed-off-by: Rayagonda Kokatanur > > This looks correct to me. > > Reviewed-by: Tyler Hicks > > It would be ideal if we could include this tag when applying the fix (or > sending a v2): > > Fixes: a9a9da47f8e6 ("mailbox: no need to check return value of debugfs_create functions") Thank you, added missing Fixes tag and sent v2. > > Thanks! > > Tyler > > > --- > > drivers/mailbox/bcm-flexrm-mailbox.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c > > index 8ee9db274802..bee33abb5308 100644 > > --- a/drivers/mailbox/bcm-flexrm-mailbox.c > > +++ b/drivers/mailbox/bcm-flexrm-mailbox.c > > @@ -1599,6 +1599,7 @@ static int flexrm_mbox_probe(struct platform_device *pdev) > > 1 << RING_CMPL_ALIGN_ORDER, 0); > > if (!mbox->cmpl_pool) { > > ret = -ENOMEM; > > + goto fail_destroy_bd_pool; > > } > > > > /* Allocate platform MSIs for each ring */ > > @@ -1661,6 +1662,7 @@ static int flexrm_mbox_probe(struct platform_device *pdev) > > platform_msi_domain_free_irqs(dev); > > fail_destroy_cmpl_pool: > > dma_pool_destroy(mbox->cmpl_pool); > > +fail_destroy_bd_pool: > > dma_pool_destroy(mbox->bd_pool); > > fail: > > return ret; > > -- > > 2.17.1 > >