Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp188534ybh; Tue, 17 Mar 2020 21:02:49 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsrFsYeYjI/S2cZIohViFTO28fW37jQfCqW4DZ5Y7e58Q1HAonE4TboGk2EEcEL1vQapCWv X-Received: by 2002:aca:3544:: with SMTP id c65mr1646333oia.160.1584504169779; Tue, 17 Mar 2020 21:02:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584504169; cv=none; d=google.com; s=arc-20160816; b=Ky00zXyN+698wvzEg8yukqXNBClkZTyOjrXHWUFJYAxOqa2isd48JkgZ4xCI29+x24 qATZg37YijQiCwHLFgMtqb0OZyxQ+aGMUURZKUdQXOlVRYaD4DkHdKjiDQYnuCHg9M8K e2RDSarj41dMS9uB+Uo8XOv4qrgIC2yGL5ISvbGjmJYraV4ketX/hrvxtXA5UPEDgcmT Nl2SSle1BBNza/5IiBDSNIpivaKYuXTowPC0h6bUz7uru6K0ZUwlGafPKuaITXXPtsIW Ha55xo2Fu13lEAh+PBSAgtSLnITEkZvy60jA2oD2vJ/BJIsJ91/5Q4IuL0nY9D87AQrK sl6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=RHI3eBLQj+bYIg7QdJEvDpIyyuTHNrhuUQTBC7hq8LQ=; b=RuE8AmjMaDx+nL7ATQE0p6X3Rc9wjfE6EIxzmh5UvQI7kSxEqZeBcJQSd7wynV8w5f KpX8kDJQZMvb8sEwiubFA5K1VrtkhV3+2IYvSpQ2RXftQ4k8P/1G8E0LWNEt1zhuKT3B ePvUQUGVIfz5hK3gZVLcoFQeNbcars+Gl9xS4bncPEXTJxHbEjVUpOXNhPKaRq0A27Rz t4iPl5uvN82Dl69sKU4uReCOErK6EhrrEFoVcZVOxXf9w2Gmmc5kxLO2EbGUt1uZp0TX 2FQt6+ffxSa35D92GbZVqnPN5EMIi9pomRuuj66R+MY3DRx+OcURrvd3Q8l+KBoKPwW4 4jcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a69si2643586oib.90.2020.03.17.21.02.37; Tue, 17 Mar 2020 21:02:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726596AbgCRECW (ORCPT + 99 others); Wed, 18 Mar 2020 00:02:22 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35458 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725298AbgCRECW (ORCPT ); Wed, 18 Mar 2020 00:02:22 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3ED71140F8B8E; Tue, 17 Mar 2020 21:02:21 -0700 (PDT) Date: Tue, 17 Mar 2020 21:02:20 -0700 (PDT) Message-Id: <20200317.210220.1278270199388080239.davem@davemloft.net> To: opendmb@gmail.com Cc: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 0/2] net: bcmgenet: revisit MAC reset From: David Miller In-Reply-To: <1584395096-41674-1-git-send-email-opendmb@gmail.com> References: <1584395096-41674-1-git-send-email-opendmb@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 17 Mar 2020 21:02:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Doug Berger Date: Mon, 16 Mar 2020 14:44:54 -0700 > Commit 3a55402c9387 ("net: bcmgenet: use RGMII loopback for MAC > reset") was intended to resolve issues with reseting the UniMAC > core within the GENET block by providing better control over the > clocks used by the UniMAC core. Unfortunately, it is not > compatible with all of the supported system configurations so an > alternative method must be applied. > > This commit set provides such an alternative. The first commit > reverts the previous change and the second commit provides the > alternative reset sequence that addresses the concerns observed > with the previous implementation. > > This replacement implementation should be applied to the stable > branches wherever commit 3a55402c9387 ("net: bcmgenet: use RGMII > loopback for MAC reset") has been applied. > > Unfortunately, reverting that commit may conflict with some > restructuring changes introduced by commit 4f8d81b77e66 ("net: > bcmgenet: Refactor register access in bcmgenet_mii_config"). > The first commit in this set has been manually edited to > resolve the conflict on net/master. I would be happy to help > stable maintainers with resolving any such conflicts if they > occur. However, I do not expect that commit to have been > backported to stable branch so hopefully the revert can be > applied cleanly. Series applied and queued up for -stable, thank you.