Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200313180333.75011-1-rajatja@google.com> <20200318035618.GG192640@dtor-ws>
In-Reply-To: <20200318035618.GG192640@dtor-ws>
From:   Rajat Jain <rajatja@google.com>
Date:   Tue, 17 Mar 2020 21:12:19 -0700
Message-ID: <CACK8Z6HXTDWteq1iVAHqw4irsWHGvAaS3apwNCicxGNreMncHg@mail.gmail.com>
Subject: Re: [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Harry Cutts <hcutts@chromium.org>,
        linux-input <linux-input@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dmitry Torokhov <dtor@google.com>,
        Rajat Jain <rajatxjain@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 17, 2020 at 8:56 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> On Fri, Mar 13, 2020 at 11:03:33AM -0700, Rajat Jain wrote:
> > New chromeos keyboards have a "snip" key that is basically a selective
> > screenshot (allows a user to select an area of screen to be copied).
> > Allocate a keycode for it.
> >
> > Signed-off-by: Rajat Jain <rajatja@google.com>
>
> Applied, thank you.

I just noticed that I had by mistake used KEY_SELECTIVE_SNAPSHOT
instead of intended KEY_SELECTIVE_SCREENSHOT in the commit message. My
apologies. Can you please fix the commit message if not already
pushed. Otherwise I can send a follow up patch if you'd like.

Thanks & Best Regards,

Rajat

>
> > ---
> > v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
> > V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
> >
> >  include/uapi/linux/input-event-codes.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > index 0f1db1cccc3fd..c4dbe2ee9c098 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -652,6 +652,8 @@
> >  /* Electronic privacy screen control */
> >  #define KEY_PRIVACY_SCREEN_TOGGLE    0x279
> >
> > +#define KEY_SELECTIVE_SCREENSHOT     0x280
> > +
> >  /*
> >   * Some keyboards have keys which do not have a defined meaning, these keys
> >   * are intended to be programmed / bound to macros by the user. For most
> > --
> > 2.25.1.481.gfbce0eb801-goog
> >
>
> --
> Dmitry