Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp205886ybh; Tue, 17 Mar 2020 21:28:43 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuOkboHv7FfkOqLh/Z+SBpQ8+fWktIgSnpjC+n3ioUeHd2eQMAtHkZXcZS1N/XHLRokLmZp X-Received: by 2002:aca:c488:: with SMTP id u130mr1818760oif.154.1584505722948; Tue, 17 Mar 2020 21:28:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584505722; cv=none; d=google.com; s=arc-20160816; b=cTtejf1sSWiTjhiTTWPVsZzxh81EXMlxxl0RyPoxcqyU1SIGRBH2s3+tv15PiBsUgx 4n17ryTc1IB/2zCDdXLCNDGgK+tr9MLpksVbWQxevMZmFWT3WJ//T5z7klDX3Lmi2T1X O32pnE7gmfjLrS7AwFAxtWdjtZwxG5qbEtph9JDFp0QVONmGoFlk9Yt8W6TFUyKjATHW UglrpaiFVh30YvnnrwyhjhPpYAh/ZPXOkALdJ5zOdRbJ+99hRbjAC4GVEAwbweVXchiM d5aQyXgb7HGxs8XfetCUH8GlIewKk0JrXHnQnrSFTTfmhXXYnfv1/AzIHz0wAcoI1uZ5 LK9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=5hQqpSvt4tC1ihG/h6rOXKsZco8EGDS57uVaABs5Le8=; b=NjtfVFteWn6Vh8EWNwNvj7apIY3YsYRxc6dTR9Ar5R4GSWek3FwjawigGCg0nMvwmi qwHFkHN8//vwEY214+ANfVujok/MPuKJD1Zy8Xy7rv/MVV+IuioMSb7LAokqBS5P01g8 AFqU9Med2K7/ZZgG/2kE74YKHHScNfVr/+eRPHvVf+jnacU4rseB1sprtbayAhuyyfMY +a33/VcFOVzDZZMbKT/n2kmT5lUs7eXBaDSTbvvirIuhJMTzuIeAf3XX32MMR65722M3 qR4KTDfJdBQi4I1w7pw/clDdilZ6M/5d9XDc38TIPKIpZltsrLbLDfvNFB47luFhj0rn TNMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jkHBtYzv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p12si2681733otq.62.2020.03.17.21.28.29; Tue, 17 Mar 2020 21:28:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jkHBtYzv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726616AbgCRE1D (ORCPT + 99 others); Wed, 18 Mar 2020 00:27:03 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44638 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbgCRE1D (ORCPT ); Wed, 18 Mar 2020 00:27:03 -0400 Received: by mail-pg1-f194.google.com with SMTP id 37so12935017pgm.11 for ; Tue, 17 Mar 2020 21:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=5hQqpSvt4tC1ihG/h6rOXKsZco8EGDS57uVaABs5Le8=; b=jkHBtYzvhoglTRpv8FIvWUG1DiqqLYXPKxhZV2s2u/ECys5cNUub5EMaQiEN0fSxyZ 6ZWxl+i2i9+jvb26DEbLyueO+Oz7femIGgayHCiqm+TL7MuREo9NyKVHuvfjjrIBW1yV zd2mi+gdahuqchxUqDeAqiiIFzfudI3QqtKTSep2DThD4cu5aii4SOt6ycbS8KvhRqSj aAL+KkEkNqUXB2a/hxVpBZaw0tmDPAD3yuc0VDjV1gqzBHcljWEHYSNfVduv8/FUkzsj 9uY0PxmdVqk3GsnUdthJfLSDwzCpf6QLGIG1HXkA1v1loK5ety8WUcvzosjvPuW5lG8N Jm6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5hQqpSvt4tC1ihG/h6rOXKsZco8EGDS57uVaABs5Le8=; b=RpoJBoH1MLq07HigaSN/IiYrT/jj4Mc0FfLEd3m1oR1SwjjCRFYTSEd4KKsJYVfB6I bcELSQE5EiOdpuTWekr5A8Jda9aNn+D9ekN3671APaEXt9d1XDptJy/Rsq7Jsn/R7K0g W5Olr41BlVRbg+Y0+ePco1gd3mQ9YrC+z3lRS54EIF6RTrgdeaSYo6TT4YgMHnQMrw8B A7Uvz9P9ujf/HqujiFidUKxUESc4AZu/xtBZV1uYQP2TWSDWar8FkIK6i+GQdPq9P1tp rpisCQrJIFfYmSqd48zHhoJbf2Ttd3md5Pq14TNb1h49yve1ITCe2wIA8MGwZ45k5uCf VG9A== X-Gm-Message-State: ANhLgQ25l1B79IMq+0tLkWhxNDBxcUEHg6r528ClG5aRxheZPYhL51NU 36EoOZ85ZiofMnrGlCoCk1TqPGjp X-Received: by 2002:a63:7e49:: with SMTP id o9mr2776478pgn.80.1584505620617; Tue, 17 Mar 2020 21:27:00 -0700 (PDT) Received: from [10.80.50.61] ([203.205.141.39]) by smtp.gmail.com with ESMTPSA id h4sm4400087pfo.87.2020.03.17.21.26.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2020 21:27:00 -0700 (PDT) Subject: Re: [PATCH] mm: Fix a comment typo To: James Bottomley , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <0783042a-244c-0c2e-091d-e7002718d73f@gmail.com> <1584503945.15565.23.camel@HansenPartnership.com> From: brookxu Message-ID: Date: Wed, 18 Mar 2020 12:26:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1584503945.15565.23.camel@HansenPartnership.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you very much for your reply, it should be my misunderstanding, thanks again~ James Bottomley wrote on 2020/3/18 11:59: > On Wed, 2020-03-18 at 11:42 +0800, brookxu wrote: >> Signed-off-by: Chunguang Xu >> >> --- >> mm/page-writeback.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/page-writeback.c b/mm/page-writeback.c >> index 2caf780..2acf754 100644 >> --- a/mm/page-writeback.c >> +++ b/mm/page-writeback.c >> @@ -1271,7 +1271,7 @@ static void wb_update_dirty_ratelimit(struct >> dirty_throttle_control *dtc, >> */ >> >> /* >> - * dirty_ratelimit will follow balanced_dirty_ratelimit iff >> + * dirty_ratelimit will follow balanced_dirty_ratelimit if > Are you sure it's a mistake? iff means if and only if which would be > reasonable unless the condition is only implies. > > James >