Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp245048ybh; Tue, 17 Mar 2020 22:24:52 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvoBm4+0FQp61fPNHBlI75QIuyQdThddXuxikqjPD2ER2O0KjXEGeHoVThGuq9aLAiGxUQZ X-Received: by 2002:a9d:638a:: with SMTP id w10mr2516412otk.103.1584509092016; Tue, 17 Mar 2020 22:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584509092; cv=none; d=google.com; s=arc-20160816; b=g9os2T4VAUcJf+TVbY+Csz25KZQD8bVaXh32Zgbp/v2RDxKH0YK1dnH3GwLaeRo9c2 4iBVSuk89qEgfTHEnAtv3JoKZLFmQx7VtZAYyPlPnMSgRWdV0yEDvcNjLYoCxdWBPGdq 8k8CYYA2GknyBVGTMz5ZEPneh+5Wwbf18LUFBzctuH5A2C29VTYiqy4dNTSntsOy7Q2M ryP7A3fc/GGyS7rw5rCsGVw6w3j+4fj+l9hokW/Ms0O4EM+EBGxI1Nl1pIla7figRb4B BMFBoFp4qUMYWJWvO3pxP8M8dZh2e930PPzs0FJI1XfWhDiYChgze1i7HX6ZsVIDhpgR uJSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=w4/gt3G1uQR8qk8iyx6so7FAdignRf9eDhsuZKI9FH8=; b=tY624Plieu+Xc+lCQYhPwnK+9Yljkdu5RJOO8AthHKRcl5srI20tQoTOpya0OnP0I9 lmfvt+19URTi60/d+U0z9lL5t7SRRxruLUdmquhKMe5XI/fhD3TlG5cjo2gM7Ot9HfOX X6OyKzjWFuzqZ05pol0XN1xETl0ARytfS8ydw4RqD+iiDLvZBcNzsD9/LnelC20k7NGo pujXTXh4D5MGDpVoImUtzTvQnzbHX35dpr+ThqCbjnzwndwHy+70pKsGOI6CKkiw0b2x V5YbtHvzhWAPOeT7datov/xpI0ItwCFOc8D8k0sJeiehnTblnyYg323htqpGG1JAvSuw RsRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v9si1771139otn.120.2020.03.17.22.24.36; Tue, 17 Mar 2020 22:24:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726607AbgCRFWn (ORCPT + 99 others); Wed, 18 Mar 2020 01:22:43 -0400 Received: from m17617.mail.qiye.163.com ([59.111.176.17]:35382 "EHLO m17617.mail.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbgCRFWn (ORCPT ); Wed, 18 Mar 2020 01:22:43 -0400 Received: from ubuntu.localdomain (unknown [58.251.74.227]) by m17617.mail.qiye.163.com (Hmail) with ESMTPA id E5CB2261414; Wed, 18 Mar 2020 13:22:33 +0800 (CST) From: Wang Wenhu To: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: trivial@kernel.org, kernel@vivo.com, Wang Wenhu Subject: [PATCH] mm: clarify a confusing comment for vm_iomap_memory Date: Tue, 17 Mar 2020 22:22:06 -0700 Message-Id: <20200318052206.105104-1-wenhu.wang@vivo.com> X-Mailer: git-send-email 2.17.1 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZTlVPSEpCQkJNQ0hIQ0tKSFlXWShZQU hPN1dZLVlBSVdZCQ4XHghZQVk1NCk2OjckKS43PlkG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Okk6ERw5TjgyTzQtPTwXCRwK AhoKFE1VSlVKTkNPTktDQk5NT05LVTMWGhIXVQweFRMOVQwaFRw7DRINFFUYFBZFWVdZEgtZQVlO Q1VJTkpVTE9VSUlMWVdZCAFZQUpMSUk3Bg++ X-HM-Tid: 0a70ec17e6e69375kuwse5cb2261414 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The param "start" actually referes to the physical memory start, which is to be mapped into virtual area vma. And it is the field vma->vm_start which stands for the start of the area. Most of the time, we do not read through whole implementation of a function but only the definition and essential comments. Accurate comments are definitely the base stone. Signed-off-by: Wang Wenhu --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index 583f84519870..5c356a57b892 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2009,7 +2009,7 @@ EXPORT_SYMBOL(remap_pfn_range); /** * vm_iomap_memory - remap memory to userspace * @vma: user vma to map to - * @start: start of area + * @start: start of the physical memory to be mapped * @len: size of area * * This is a simplified io_remap_pfn_range() for common driver use. The -- 2.17.1