Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1578560282.git.benchuanggli@gmail.com> <9f861920380df9d7a6d52c905fc47643eb25f33f.1578560282.git.benchuanggli@gmail.com>
 <add27a04-e018-d050-4d42-4fb5c532df8c@intel.com>
In-Reply-To: <add27a04-e018-d050-4d42-4fb5c532df8c@intel.com>
From:   Ben Chuang <benchuanggli@gmail.com>
Date:   Wed, 18 Mar 2020 14:53:08 +0800
Message-ID: <CACT4zj-M-BJKSwDNA7dRa88N8A4PBoX0GnMZiSMKum4GGiTiFA@mail.gmail.com>
Subject: Re: [RFC PATCH v2 3/6] mmc: host: Add UHS-II support in host layer
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        greg.tu@genesyslogic.com.tw,
        Ben Chuang <ben.chuang@genesyslogic.com.tw>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 17, 2020 at 4:18 PM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 9/01/20 11:14 am, Ben Chuang wrote:
> > From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> >
> > Add UHS-II support in host layer
>
> Split host layer changes from sdhci changes.
>
> >
> > Reported-by: kbuild test robot <lkp@intel.com>
>
> Drop "Reported-by: kbuild test robot <lkp@intel.com>"
>
> > Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> > ---
> >  drivers/mmc/host/Makefile                  |   1 +
> >  drivers/mmc/host/{sdhci.c => sdhci-core.c} | 276 ++++++--
> >  drivers/mmc/host/sdhci-milbeaut.c          |   4 +-
> >  drivers/mmc/host/sdhci-of-arasan.c         |   4 +-
> >  drivers/mmc/host/sdhci-of-at91.c           |   4 +-
> >  drivers/mmc/host/sdhci-omap.c              |   2 +-
> >  drivers/mmc/host/sdhci-pci-core.c          |   4 +-
> >  drivers/mmc/host/sdhci-pxav3.c             |   4 +-
> >  drivers/mmc/host/sdhci-uhs2.c              | 751 +++++++++++++++++++++
> >  drivers/mmc/host/sdhci-uhs2.h              |  34 +
> >  drivers/mmc/host/sdhci-xenon.c             |   4 +-
> >  drivers/mmc/host/sdhci.h                   | 284 +++++++-
> >  drivers/mmc/host/sdhci_am654.c             |   4 +-
> >  include/linux/mmc/uhs2.h                   | 270 ++++++++
> >  14 files changed, 1583 insertions(+), 63 deletions(-)
> >  rename drivers/mmc/host/{sdhci.c => sdhci-core.c} (94%)
> >  create mode 100644 drivers/mmc/host/sdhci-uhs2.c
> >  create mode 100644 drivers/mmc/host/sdhci-uhs2.h
> >  create mode 100644 include/linux/mmc/uhs2.h
>
> Please make sdhci-uhs2 a module and do not rename sdhci.c.
>
> References in sdhci.c to sdhci-uhs2.c will need to be enclosed by
> #if IS_REACHABLE(CONFIG_SDHCI_UHS2)
>
> Move all UHS-II definitions into sdhci-uhs2.h.  Things that are for V4 but
> not necessarily UHS-II can be in sdhci.h
>
> Make the set_power parameter change into a separate patch
>
> Fix all spelling mistakes
>
> Make comment style correct.
>
> Review all checkpatch warnings and checks (i.e. --strict option)
>
> If possible provide a link to a tree that contains the patches.
>
> Re-base on Ulf's next branch
>
> The patch set could use an overview of how UHS-II is different from regular SD.
>
> In other patches there are a bunch of memory allocations on the I/O path.
> That is a problem.  Memory needed should be allocated in advance.

Thanks for your comments and guidance.
There seems to be a lot of work to do. I will do my best to meet these.