Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200312083341.9365-1-jian-hong@endlessm.com> <20200312104643.GA15619@zn.tnic>
 <CAPpJ_eetjhmPwXXXn2y-vibRCK6rrKsFZgC+YGzxO4fMrCKpuQ@mail.gmail.com> <20200316100201.GG26126@zn.tnic>
In-Reply-To: <20200316100201.GG26126@zn.tnic>
From:   Jian-Hong Pan <jian-hong@endlessm.com>
Date:   Wed, 18 Mar 2020 14:58:54 +0800
Message-ID: <CAPpJ_echFt1LbMbjka4r=gPBF9XqGbFUOmUmB8Wi5p9TVK2wuA@mail.gmail.com>
Subject: Re: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer
 TravelMate X514-51T"
To:     Borislav Petkov <bp@alien8.de>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>, x86@kernel.org,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        linux-efi@vger.kernel.org,
        Linux Upstreaming Team <linux@endlessm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Borislav Petkov <bp@alien8.de> =E6=96=BC 2020=E5=B9=B43=E6=9C=8816=E6=97=A5=
 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=886:01=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Mon, Mar 16, 2020 at 05:17:56PM +0800, Jian-Hong Pan wrote:
> > But, that will raise another question:  Since the original quirk works
> > for all Acer X514-51T and the quirk cannot be removed for older BIOS.
> > Why not keep only original matching items for all Acer X514-51T
> > laptops?
>
> What does the "original matching items" mean?

I should make it more clearly.

The quirk's original matching items for Acer TravelMate X514-51T from
commit 0082517fa4bc ("x86/reboot, efi: Use EFI reboot for Acer
TravelMate X514-51T"):

        {       /* Handle reboot issue on Acer TravelMate X514-51T */
                .callback =3D set_efi_reboot,
                .ident =3D "Acer TravelMate X514-51T",
                .matches =3D {
                        DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                        DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate X514-51T"),
                },
        },

These matching items make all Acer TravelMate X514-51Ts apply the quirk.

If BIOS version condition is added like:

        {       /* Handle reboot issue on Acer TravelMate X514-51T */
                .callback =3D set_efi_reboot,
                .ident =3D "Acer TravelMate X514-51T",
                .matches =3D {
                        DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                        DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate X514-51T"),
                        DMI_MATCH(DMI_BIOS_VERSION, "V1.0"),
                },
        },

Then, only Acer TravelMate X514-51T with older BIOS (1.04 and before,
according BIOS version listed on Acer's website [1]) will apply the
quirk.
The one with newer BIOS's reboot type will be defined later by the codes.

[1] https://www.acer.com/ac/en/US/content/support-product/7889?b=3D1

> > I am not sure which option is better.  Any comment?
>
> If you mean, "let's not do anything and fix it only when there's really
> a need to fix anything", then yes, I agree.

Got it!

Thanks,
Jian-Hong Pan