Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] extcon: Mark extcon_get_edev_name() function as
 exported symbol
To:     Mayank Rana <mrana@codeaurora.org>, myungjoo.ham@samsung.com
Cc:     linux-kernel@vger.kernel.org, jackp@codeaurora.org
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <1ce81e60-8d71-de92-1295-93f9a59d0ada@samsung.com>
Date:   Wed, 18 Mar 2020 17:30:09 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <1584389672-9195-1-git-send-email-mrana@codeaurora.org>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20200316201450epcas1p3a20b0db35d64af8f50925079ca5fabf6@epcas1p3.samsung.com>
        <1584389672-9195-1-git-send-email-mrana@codeaurora.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/17/20 5:14 AM, Mayank Rana wrote:
> extcon_get_edev_name() function provides client driver to request
> extcon dev's name. If extcon driver and client driver are compiled
> as loadable modules, extcon_get_edev_name() function symbol is not
> visible to client driver. Hence mark extcon_find_edev_name() function
> as exported symbol.
> 
> Signed-off-by: Mayank Rana <mrana@codeaurora.org>
> ---
>  drivers/extcon/extcon.c | 1 +
>  include/linux/extcon.h  | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index e055893..2dfbfec 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1406,6 +1406,7 @@ const char *extcon_get_edev_name(struct extcon_dev *edev)
>  {
>  	return !edev ? NULL : edev->name;
>  }
> +EXPORT_SYMBOL_GPL(extcon_get_edev_name);
>  
>  static int __init extcon_class_init(void)
>  {
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index 1b1d77e..fd183fb 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -286,6 +286,11 @@ static inline struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev,
>  {
>  	return ERR_PTR(-ENODEV);
>  }
> +
> +static inline const char *extcon_get_edev_name(struct extcon_dev *edev)
> +{
> +	return NULL;
> +}
>  #endif /* CONFIG_EXTCON */
>  
>  /*
> 

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics