Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp456479ybh; Wed, 18 Mar 2020 03:08:04 -0700 (PDT) X-Google-Smtp-Source: ADFU+vujuab5xCnL9TJ094AzDbX8WnNB7CcnCm/3L9AmW4s8GB7myRPFYhk1+tQz6K4/ok6zs4qQ X-Received: by 2002:aca:d68e:: with SMTP id n136mr2550294oig.103.1584526084716; Wed, 18 Mar 2020 03:08:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584526084; cv=none; d=google.com; s=arc-20160816; b=IzTzd3ytPrguBNuF2E5QyS6AV+MtNC6jmdG+8Iz3b0orwkPzuhbN8UUWaPMkKxk7KC sOituJWN1Mh6Pu571Pc4rn2nhus6K1kZitBPkGTvHvo0lBLK63fZ0jQuEGyMoBlR02mu 2WUHWz04dx6hLUtKvA/1+mQ+YzXVQUnr8ghwQWexyBf1VRl4a7Jx5IO6j0SUK0bW1ARl y2Abk4lQ+n/LKhxdZTHWYDiukWvkupr5E/YCUwiK+BMxMInKro1o2ikZzOrCOFlVmBDH XpvojPG1aSghiKPxgpjbpIVCniZFpMuU3Tie0qYiLKtYq5EQ16/8z+8M+owDPIOY5aw3 jjRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=YVsKbjiUlOCo5hGCh5LuXdRWUIZabta02cID9Mlk1ms=; b=AW43brGBkgWpq1nOOj0Qt9A+zfw8klmZOQRiDIZc1jExDMSUQ5V9g0SSe4LoXe832A Y3ykolRHINGmABsMFCjpYyq37+YPbXbHTKSgfaRg7OEUeAKDoJ46rZCi4hFEH/Am0a9p HAHh84HlQQFZ7iWADoWhlrQgq8eSQHKetlCfzfq1zJgbkwUYHWFBAX2jG14J/6Vhf5rP dPWiLqknk9NgbnByCp7B8rShee9JFQji1rRcYQmIFv1wPNP0x5p935ZdbPKSHSr+P4vk 7fSBV8gKJTJiswSiOWAeKfX8BmeXGdJ5WCWxdTnr2HBUYLeyck0ESz20R/KfP2ftd8BJ bTGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1si2991587otr.322.2020.03.18.03.07.52; Wed, 18 Mar 2020 03:08:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727636AbgCRKHS (ORCPT + 99 others); Wed, 18 Mar 2020 06:07:18 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:4011 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727420AbgCRKHS (ORCPT ); Wed, 18 Mar 2020 06:07:18 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.13]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee15e71f2b0a52-116c5; Wed, 18 Mar 2020 18:06:41 +0800 (CST) X-RM-TRANSID: 2ee15e71f2b0a52-116c5 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.25.154.146]) by rmsmtp-syy-appsvr07-12007 (RichMail) with SMTP id 2ee75e71f2aeb06-c9ca4; Wed, 18 Mar 2020 18:06:41 +0800 (CST) X-RM-TRANSID: 2ee75e71f2aeb06-c9ca4 From: Tang Bin To: linux@rempel-privat.de, s.hauer@pengutronix.de Cc: shawnguo@kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH] drivers/i2c/busses/i2c-imx.c:remove duplicate print after platform_get_irq() Date: Wed, 18 Mar 2020 18:07:48 +0800 Message-Id: <20200318100748.17540-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't need dev_err() message because when something goes wrong, platform_get_irq() has print an error message itself, so we should remove duplicate dev_err(). Signed-off-by: Tang Bin --- drivers/i2c/busses/i2c-imx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index a3b61336f..01fd46682 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -1066,10 +1066,8 @@ static int i2c_imx_probe(struct platform_device *pdev) dev_dbg(&pdev->dev, "<%s>\n", __func__); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "can't get irq number\n"); + if (irq < 0) return irq; - } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap_resource(&pdev->dev, res); -- 2.20.1.windows.1