Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 3/4] iio: accel: adxl372: add additional events ABIs
To:     Alexandru Tachici <tachicialex@gmail.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     jic23@kernel.org
References: <20200318110958.8621-1-alexandru.tachici@analog.com>
 <20200318110958.8621-4-alexandru.tachici@analog.com>
From:   Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <c140a2ab-2da8-2c56-3ab6-193bb52a46cb@metafoo.de>
Date:   Wed, 18 Mar 2020 11:15:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200318110958.8621-4-alexandru.tachici@analog.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/18/20 12:09 PM, Alexandru Tachici wrote:
> Adxl372 uses the standard event interface. The additional
> ABIs aim to explain to the user that the values set in
> ./events/thresh_falling_period and ./events/thresh_rising_period
> control the state of the device, not just the events timings.
> 

Hi,

I'm not convinced this is a good idea. Since this is non-standard ABI 
the user would likely have to consult the documentation to figure out 
what this means. So we might as well document in the documentation that 
for peak mode the thresholds are configured through the event API.

- Lars