Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp466985ybh; Wed, 18 Mar 2020 03:20:18 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtYy1DiZRKlqP6mnnXliY10w5bslMID+ETgtcuA9b/09OQdaCy41MYXSdz8ESmGs1uG/gJl X-Received: by 2002:a9d:7857:: with SMTP id c23mr3246330otm.288.1584526818746; Wed, 18 Mar 2020 03:20:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584526818; cv=none; d=google.com; s=arc-20160816; b=IbIiJf5E0W3nuBeFI8ED2BPXQLI1G/vdpue6zxa0YcjKCnyuP/L1/4/Qoe3DGVmpyn gOrmUlbCht1yce5VWSQeRgagUDIm/YjFZyk39OB8nv4slYBFUbUMwkgrRn8deIxCf3/w kke9IOJk6xOSNb37q7yVppQnpGG+Ni8wxrcfypra/Ri+hv8NY/4LVvi3VDcEW9JzE6d8 YS4TpgSRyxvjoQvjuRDdCMccXtL7H1h0M8PCST0ONe3l27vu1KKACeuIYpyT5rOt7R0h TP3r3hHpWGN6oGb8qEvOx3nzHZNfuyyw5rO3qP5zQhWSNcpTMEPJiYOx+uWbw7U4BRYr 5IeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=t01fhWNp1IRXO32y9v3L1IxmXyRwLvORUavbkYC8gO4=; b=rLuHh6PMAzayie99tzBraEDsNi1OmR30BiIZLN6K1BieDY6hAf06z3cffE05KO2DTq xccmhyGgNTltYQtuWC/J+geKmUcZTTmY09rt6Oxwj9IwEI/7KWiz6oMYXzyyh9adFw1f SbfIMhw5NVugpNYKSlyV1ys3eQxfU6IlZ9ePczWHOaEDUB16o9bY3QnHh5eYDnEMTBiv +cmRGm6aiXeVr7AHRXT2hZbka7F1b3ciLd+MVBJbBgBirEkHuHpjIQ2TCezR4PTTg3cF i6LypYCJhvvl7rmgKVsALLDK/12yFHoxRsUa0UDRw18TNnrWj18hA9MMuMeRgsBThw8D KgXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="ADYpT/no"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y3si3142431oti.195.2020.03.18.03.20.05; Wed, 18 Mar 2020 03:20:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="ADYpT/no"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727635AbgCRKTd (ORCPT + 99 others); Wed, 18 Mar 2020 06:19:33 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:28998 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726786AbgCRKTd (ORCPT ); Wed, 18 Mar 2020 06:19:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584526772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t01fhWNp1IRXO32y9v3L1IxmXyRwLvORUavbkYC8gO4=; b=ADYpT/no2EVaCuUjpWuHZNIRY77eX4JqHB8xWXgMsxh47sMb+glK/Qi3xmQ6vxO2zR76QU g7DFWBal9yGQE95pLMqMRwWOFAWy0onawcoZFVWQdmxWo3G7VTfEJnx4EUUswJP8zjl2bh WPvPggiAXEdq3uc6DI+SWA14UYPbQT4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-416-BCLxyEjRMZOmdsNyN1yuxA-1; Wed, 18 Mar 2020 06:19:30 -0400 X-MC-Unique: BCLxyEjRMZOmdsNyN1yuxA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F970107ACCC; Wed, 18 Mar 2020 10:19:29 +0000 (UTC) Received: from krava (unknown [10.40.195.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B453B92D0E; Wed, 18 Mar 2020 10:19:25 +0000 (UTC) Date: Wed, 18 Mar 2020 11:19:15 +0100 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v2 00/14] perf: Stream comparison Message-ID: <20200318101915.GB821557@krava> References: <20200313071118.11983-1-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200313071118.11983-1-yao.jin@linux.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2020 at 03:11:04PM +0800, Jin Yao wrote: SNIP > > v2: > --- > Refine the codes for following patches: > perf util: Create source line mapping table > perf util: Create streams for managing top N hottest callchains > perf util: Calculate the sum of all streams hits > perf util: Add new block info functions for top N hot blocks comparison > > Jin Yao (14): > perf util: Create source line mapping table > perf util: Create streams for managing top N hottest callchains > perf util: Return per-event callchain streams > perf util: Compare two streams > perf util: Calculate the sum of all streams hits > perf util: Report hot streams > perf diff: Support hot streams comparison > perf util: Add new block info functions for top N hot blocks > comparison > perf util: Add new block info fmts for showing hot blocks comparison > perf util: Enable block source line comparison > perf diff: support hot blocks comparison > perf util: Filter out streams by name of changed functions > perf util: Filter out blocks by name of changed functions > perf diff: Filter out streams by changed functions I can't apply this on latest perf/core, do you have it in git tree branch? thanks, jirka > > tools/perf/Documentation/perf-diff.txt | 19 + > tools/perf/builtin-diff.c | 324 ++++++++++++--- > tools/perf/util/Build | 1 + > tools/perf/util/block-info.c | 433 ++++++++++++++++++- > tools/perf/util/block-info.h | 38 +- > tools/perf/util/callchain.c | 517 +++++++++++++++++++++++ > tools/perf/util/callchain.h | 34 ++ > tools/perf/util/srclist.c | 555 +++++++++++++++++++++++++ > tools/perf/util/srclist.h | 74 ++++ > 9 files changed, 1935 insertions(+), 60 deletions(-) > create mode 100644 tools/perf/util/srclist.c > create mode 100644 tools/perf/util/srclist.h > > -- > 2.17.1 >