Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp497291ybh; Wed, 18 Mar 2020 03:58:59 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtrZe52PRcqZapMOa+3297Bd/xG+wxTMPqFE9dCl+227TKuZw/nGAhfbmS1/vB6slUEubWT X-Received: by 2002:a05:6808:103:: with SMTP id b3mr2732432oie.46.1584529139061; Wed, 18 Mar 2020 03:58:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584529139; cv=none; d=google.com; s=arc-20160816; b=O33ytwtP4AgJ7eqKvKp3uV+HIOQjC+pQt0q+0X+crVg/CKUI/+Co9iSsSnd1T9kOoV +wL9DjqncD1OVMjbzSW8z17/xrqr0Vw9kBiTLIYiQpEEg73BZxtrXX+NeP6yQJZZI86r 7KIbDC6wrWWU53eaV2ywzpVIHoKfpFw0U8KeAz8Hn1INLNmPQl5vTm7tP/hYyxWsGmsW +NvNvaZOYHUrvR3gJyE8FDZR8pGVRVM00VN6AX2nVIN3ETRRaZ3mqsZk+miIy7y+yNRg Gz2WopXiBBVNXXlCj7mSVcUK7p/S6WASEX76rUn8pD16huPc/WGBHaVRWv55oP0k7VH2 f7/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nV3Qdu0HYWee3j5+6+aGekWI3rUXVXUf4iMVPL1IdEw=; b=RqQU7V1rUFUKcsy9DelGpr0XyAzXenQgvqkw+JWBvmlyfMcJK1/8NCDYGOYFKGzdZg HugoRKL3hhKcBAVttd31oWo2is7r6r86MsLDP6ScZBcY7Ak3pQ62GkGC1RdmtvpMyK+b xcl7k/WgcpoCMczXZJT31kvpPeuTZfxVpzy7a2weo5+14+EIlLm0qD4vt+pnqCebbY69 hJb+y50D7JtWwdla8irCyd3fhNODhVnC9UQIEVktJ8zMFx6nNtIi1U21Od8vjVwG4Sog pLi5eM4cXnat4DF/V22X8EQZhOX5gTgr7ETjeKiW2jtr6BVdxDB+zOXyr/auncwYUGnM uubQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vQMcUSiu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 66si3184049otx.151.2020.03.18.03.58.47; Wed, 18 Mar 2020 03:58:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vQMcUSiu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727702AbgCRK5v (ORCPT + 99 others); Wed, 18 Mar 2020 06:57:51 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:44683 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbgCRK5u (ORCPT ); Wed, 18 Mar 2020 06:57:50 -0400 Received: by mail-lj1-f196.google.com with SMTP id w4so11751476lji.11 for ; Wed, 18 Mar 2020 03:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nV3Qdu0HYWee3j5+6+aGekWI3rUXVXUf4iMVPL1IdEw=; b=vQMcUSiu8Ef0t/A+g7adc3drzAiCtfzj33O0acSrVOG2GH/5HUcySiy/OVWguyqDH8 6q4v6t92onicU3oTLVR4CXmPiztXSa8MgRhdKRrkBmkRBwKelns6VtY0l5Zj66cDOTzZ tWV6S3ScsVbJYqgW3yeSzxir4h8mLgggfwYzxGjhHSEw4Oi4uxi2lNWHiiszt6+EMbK7 cljVksEQPxpT8QkS8aqy5jFCYesMSUO6c1ioO9QziWcEDhjP1MzIS0P+KgDrPZ3YPDe1 Y1D8pJS8UkGfI4p31s2MqwDM8AQZDLCCcgaGnZ6/pddL86EplPtt9qmLIVfm9BCP0UHW 2Qbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nV3Qdu0HYWee3j5+6+aGekWI3rUXVXUf4iMVPL1IdEw=; b=mRiNJyaMCagTY3Y+zEcD0shQPVe5qRBTZBR9ZC6rtpG0GD8n2mDu7uysbFs+nFAB8G K3I4Gc8DPGh4u0D8Vu/l0+4WlPlcWYCWlfwiQDerbsgq5iQW9w4c8Fe6AoXen1wZQKJ3 GOkFPniZ1JpkO7zEorO1XUaZN5iXSH7CKBJnq2PtcnfxU9AShdkTlxkmF2yXszFo6s/G lOGBgQJhcpE4V3iFewWgUgj7RwHWLSFlvh6P6gS4FdZLivYjbFwheE+VxRWDMjXbm5/h IWBPwgnUoMpSHc+Y74p2pZxkitCIsGBdcvNlLhy7madYzu79naUCZushHCaU7xyMtNk/ 3KEA== X-Gm-Message-State: ANhLgQ1rA24x00dCprkGwm6DLyX/QdKWz729NQYdW0QySfwFuWUBj2Yo lWs82iEZyN1sLd+LhAwSjcA= X-Received: by 2002:a2e:b60d:: with SMTP id r13mr2056552ljn.185.1584529069502; Wed, 18 Mar 2020 03:57:49 -0700 (PDT) Received: from uranus.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id t1sm4114152lji.98.2020.03.18.03.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 03:57:48 -0700 (PDT) Received: by uranus.localdomain (Postfix, from userid 1000) id BC321461840; Wed, 18 Mar 2020 13:57:47 +0300 (MSK) Date: Wed, 18 Mar 2020 13:57:47 +0300 From: Cyrill Gorcunov To: Adrian Reber Cc: Christian Brauner , Eric Biederman , Pavel Emelyanov , Oleg Nesterov , Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin , linux-kernel@vger.kernel.org, Mike Rapoport , Radostin Stoyanov , Michael Kerrisk , Arnd Bergmann , Thomas Gleixner Subject: Re: [PATCH 1/4] ns: prepare time namespace for clone3() Message-ID: <20200318105747.GP27301@uranus> References: <20200317083043.226593-1-areber@redhat.com> <20200317083043.226593-2-areber@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317083043.226593-2-areber@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2020 at 09:30:41AM +0100, Adrian Reber wrote: ... > +/* > + * This structure is used to set the time namespace offset > + * via /proc as well as via clone3(). > + */ > +struct set_timens_offset { > + int clockid; > + struct timespec64 val; > +}; > + I'm sorry, I didn't follow this series much so can't comment right now. Still this structure made me a bit wonder -- the @val seems to be 8 byte aligned and I guess we have a useless pad between these members. If so can we swap them? Or it is already part of api?