Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
References: <20200317123231.2843297-1-oleksandr.suvorov@toradex.com>
 <20200317123231.2843297-5-oleksandr.suvorov@toradex.com> <20200317230115.GM2527@pendragon.ideasonboard.com>
In-Reply-To: <20200317230115.GM2527@pendragon.ideasonboard.com>
From:   Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Date:   Wed, 18 Mar 2020 13:37:00 +0200
Message-ID: <CAGgjyvEneCwFM8_tnKfNprqw2qkL_94rpsGF=ZgW-m75JBvegw@mail.gmail.com>
Subject: Re: [RFC PATCH 4/7] dt-bindings: pwm: add description of PWM polarity
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
        Paul Barker <pbarker@konsulko.com>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Igor Opaniuk <igor.opaniuk@toradex.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mail-qv1-f54.google.com (209.85.219.54) by MN2PR18CA0009.namprd18.prod.outlook.com (2603:10b6:208:23c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.22 via Frontend Transport; Wed, 18 Mar 2020 11:37:15 +0000
Received: by mail-qv1-f54.google.com with SMTP id cy12so6743996qvb.7;        Wed, 18 Mar 2020 04:37:15 -0700 (PDT)
X-Gm-Message-State: ANhLgQ1iEP6of7LUhN0elNhib0QOdOCQwFhgBLzXdLCDSPS9hVy5LFqC
        8aWDsmLfXVmhpnE6fXlC1cqX4w0W24AXUTCn4+s=
X-Received: by 2002:ad4:4e10:: with SMTP id dl16mr3840515qvb.44.1584531431943;
 Wed, 18 Mar 2020 04:37:11 -0700 (PDT)
X-Gmail-Original-Message-ID: <CAGgjyvEneCwFM8_tnKfNprqw2qkL_94rpsGF=ZgW-m75JBvegw@mail.gmail.com>
X-Originating-IP: [209.85.219.54]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ac37f86f-3b87-4102-5a97-08d7cb30b50b
X-MS-TrafficTypeDiagnostic: VI1PR05MB6493:
X-Microsoft-Antispam-PRVS: <VI1PR05MB6493C9C9F423B4F563F89D99F9F70@VI1PR05MB6493.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-Forefront-PRVS: 03468CBA43
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4636009)(39850400004)(366004)(136003)(376002)(396003)(346002)(199004)(52116002)(9686003)(44832011)(55446002)(450100002)(5660300002)(186003)(26005)(55236004)(2906002)(42186006)(6666004)(4326008)(54906003)(6862004)(53546011)(316002)(81156014)(81166006)(8676002)(66556008)(8936002)(66946007)(66476007)(86362001)(478600001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR05MB6493;H:VI1PR05MB3279.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;
Received-SPF: None (protection.outlook.com: toradex.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: HOYJh5/+FoT85ILJE/erSf+vUeNr/4lhaFMnspidW2SSU68D1B90glkSnFQRk6g/V+3ZakEX0yYaF2olxFgAePE3zvBAIO5uYjVYRSqM2EfQly2BIO3tZBYbEcxrmPpFAUmZ3tBUuGOXJOxBMyRIq0PSLOjLJUfYxR5b2I+5W+9YxcDNdBr0XsXuYtMuOj9DYFGZGdwQgQpzts3q0sihkmZkxNCPmDr/aSpjsfUTDs/9Y7p+ALobdohRMDJJzS934Bskg48gqEKIH2n8HYuZ49qB9p8ppMrXvfUjS5CxZhZzeYqbGc5RcGjRR/ycP9u7aVA896gU8OO3Wa6zx2zKHRijtr0C0UdNWAHEzYRFFpnHMmy8PRALaEJ+kaJ+JFZRI7ZTzktiBvHdFFkrQgCfydS9Upb1DHmf4hv8KuinLFWrdACIr461+vqKng72ELNX
X-MS-Exchange-AntiSpam-MessageData: PucYqdzj5+JFRR5fUB212zRl1fljno6Kn1ggxn5lSNotHSgDZWX62BNwNd2EY53DLn9OOfDdMCn3GtlJdqFJcw5NPIE20lHLwnNFXrWw1Rs6sdKpfrzcJSkSJadOYMokpy/4TVSfSNBEQCuRFVoXmA==
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac37f86f-3b87-4102-5a97-08d7cb30b50b
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2020 11:37:15.4292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rP4LQJUlMP1b6usNMMheJKBu11e+mrs1hFHMpcWbHTrRgY5m48pyaea21qHwSTPHBw/PaQa07uBXi3VETp+4UVtZP7ji0ym50A0tzKKcrjE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB6493
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 18, 2020 at 1:02 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Oleksandr,
>
> Thank you for the patch.
>
> On Tue, Mar 17, 2020 at 02:32:28PM +0200, Oleksandr Suvorov wrote:
> > Move the description of the PWM signal polarity from
> > <linux/pwm.h>, prepare for removing the polarity
> > definition from <linux/pwm.h>.
> >
> > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> > ---
> >
> >  include/dt-bindings/pwm/pwm.h | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/include/dt-bindings/pwm/pwm.h b/include/dt-bindings/pwm/pwm.h
> > index 6b58caa6385e..c07da2088a61 100644
> > --- a/include/dt-bindings/pwm/pwm.h
> > +++ b/include/dt-bindings/pwm/pwm.h
> > @@ -10,7 +10,16 @@
> >  #ifndef _DT_BINDINGS_PWM_PWM_H
> >  #define _DT_BINDINGS_PWM_PWM_H
> >
> > +/**
> > + * a high signal for the duration of the duty-cycle, followed by a low signal
> > + * for the remainder of the pulse period.
> > + */
>
> Last time I checked, kernedoc didn't support documenting macros (enums
> are supported).

That's why I dropped the kerneldoc tags leaving the descriptions only.

> >  #define PWM_POLARITY_NORMAL                  0
> > +
> > +/**
> > + * a low signal for the duration of the duty-cycle, followed by a high signal
> > + * for the remainder of the pulse period.
> > + */
> >  #define PWM_POLARITY_INVERTED                        (1 << 0)
> >
> >  #endif
>
> --
> Regards,
>
> Laurent Pinchart

-- 
Best regards
Oleksandr Suvorov

Toradex AG
Ebenaustrasse 10 | 6048 Horw | Switzerland | T: +41 41 500 48 00